You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Chamila De Alwis <ch...@wso2.com> on 2014/08/25 10:59:29 UTC
Link to /console from Error Page Logo instead of /
Hi,
The logo of the error pages produced by Stratos Manager links to "/" which
gets redirected to "/carbon" and presents the user with Carbon console. I
think the correct approach is to link it to "/console" so that the user
will land back on where he/she was working.
I attached the suggested fix.
diff --git
components/org.apache.stratos.manager.console/console/error-404.html
components/org.apache.stratos.manager.console/consol
index 71ad847..5f121d0 100644
--- components/org.apache.stratos.manager.console/console/error-404.html
+++ components/org.apache.stratos.manager.console/console/error-404.html
@@ -67,7 +67,7 @@
<div class="container">
<div class="row">
<div class="col-lg-12">
- <a style="margin-top: 20px;display: inline-block"
href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
*+ <a style="margin-top: 20px;display: inline-block"
href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
<h1>OOPS!</h1>
</div>
diff --git components/org.apache.stratos.manager.console/console/error.html
components/org.apache.stratos.manager.console/console/er
index c4436ec..c562b1c 100644
--- components/org.apache.stratos.manager.console/console/error.html
+++ components/org.apache.stratos.manager.console/console/error.html
@@ -67,7 +67,7 @@
<div class="container">
<div class="row">
<div class="col-lg-12">
- <a style="margin-top: 20px;display: inline-block"
href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
*+ <a style="margin-top: 20px;display: inline-block"
href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
<h1>OOPS!</h1>
</div>
Regards,
Chamila de Alwis
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com
Re: Link to /console from Error Page Logo instead of /
Posted by Udara Liyanage <ud...@wso2.com>.
Hi Chamila,
Commited with bfed0e6cafa3a33c366492ef1efa848a72d6d491
On Mon, Aug 25, 2014 at 3:23 PM, Udara Liyanage <ud...@wso2.com> wrote:
> Hi Chamila,
>
> Can you send a PR for this?
>
>
> On Mon, Aug 25, 2014 at 3:05 PM, Chamila De Alwis <ch...@wso2.com>
> wrote:
>
>> opened at https://issues.apache.org/jira/browse/STRATOS-760
>>
>> Attached the patch file to the issue.
>>
>>
>> Regards,
>> Chamila de Alwis
>> Software Engineer | WSO2 | +94772207163
>> Blog: code.chamiladealwis.com
>>
>>
>>
>>
>> On Mon, Aug 25, 2014 at 2:33 PM, Nirmal Fernando <ni...@gmail.com>
>> wrote:
>>
>>> +1.. thanks Chamila for the fix. Can you please create a jira and send a
>>> PR against that?
>>>
>>>
>>> On Mon, Aug 25, 2014 at 2:29 PM, Chamila De Alwis <ch...@wso2.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> The logo of the error pages produced by Stratos Manager links to "/"
>>>> which gets redirected to "/carbon" and presents the user with Carbon
>>>> console. I think the correct approach is to link it to "/console" so that
>>>> the user will land back on where he/she was working.
>>>>
>>>> I attached the suggested fix.
>>>>
>>>>
>>>> diff --git
>>>> components/org.apache.stratos.manager.console/console/error-404.html
>>>> components/org.apache.stratos.manager.console/consol
>>>> index 71ad847..5f121d0 100644
>>>> --- components/org.apache.stratos.manager.console/console/error-404.html
>>>> +++ components/org.apache.stratos.manager.console/console/error-404.html
>>>> @@ -67,7 +67,7 @@
>>>> <div class="container">
>>>> <div class="row">
>>>> <div class="col-lg-12">
>>>> - <a style="margin-top: 20px;display: inline-block"
>>>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>>>> *+ <a style="margin-top: 20px;display: inline-block"
>>>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>>>
>>>> <h1>OOPS!</h1>
>>>> </div>
>>>> diff --git
>>>> components/org.apache.stratos.manager.console/console/error.html
>>>> components/org.apache.stratos.manager.console/console/er
>>>> index c4436ec..c562b1c 100644
>>>> --- components/org.apache.stratos.manager.console/console/error.html
>>>> +++ components/org.apache.stratos.manager.console/console/error.html
>>>> @@ -67,7 +67,7 @@
>>>> <div class="container">
>>>> <div class="row">
>>>> <div class="col-lg-12">
>>>> - <a style="margin-top: 20px;display: inline-block"
>>>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>>>> *+ <a style="margin-top: 20px;display: inline-block"
>>>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>>>
>>>> <h1>OOPS!</h1>
>>>> </div>
>>>>
>>>>
>>>>
>>>>
>>>> Regards,
>>>> Chamila de Alwis
>>>> Software Engineer | WSO2 | +94772207163
>>>> Blog: code.chamiladealwis.com
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>
>
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
Re: Link to /console from Error Page Logo instead of /
Posted by Udara Liyanage <ud...@wso2.com>.
Hi Chamila,
Can you send a PR for this?
On Mon, Aug 25, 2014 at 3:05 PM, Chamila De Alwis <ch...@wso2.com> wrote:
> opened at https://issues.apache.org/jira/browse/STRATOS-760
>
> Attached the patch file to the issue.
>
>
> Regards,
> Chamila de Alwis
> Software Engineer | WSO2 | +94772207163
> Blog: code.chamiladealwis.com
>
>
>
>
> On Mon, Aug 25, 2014 at 2:33 PM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> +1.. thanks Chamila for the fix. Can you please create a jira and send a
>> PR against that?
>>
>>
>> On Mon, Aug 25, 2014 at 2:29 PM, Chamila De Alwis <ch...@wso2.com>
>> wrote:
>>
>>> Hi,
>>>
>>> The logo of the error pages produced by Stratos Manager links to "/"
>>> which gets redirected to "/carbon" and presents the user with Carbon
>>> console. I think the correct approach is to link it to "/console" so that
>>> the user will land back on where he/she was working.
>>>
>>> I attached the suggested fix.
>>>
>>>
>>> diff --git
>>> components/org.apache.stratos.manager.console/console/error-404.html
>>> components/org.apache.stratos.manager.console/consol
>>> index 71ad847..5f121d0 100644
>>> --- components/org.apache.stratos.manager.console/console/error-404.html
>>> +++ components/org.apache.stratos.manager.console/console/error-404.html
>>> @@ -67,7 +67,7 @@
>>> <div class="container">
>>> <div class="row">
>>> <div class="col-lg-12">
>>> - <a style="margin-top: 20px;display: inline-block"
>>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>>> *+ <a style="margin-top: 20px;display: inline-block"
>>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>>
>>> <h1>OOPS!</h1>
>>> </div>
>>> diff --git
>>> components/org.apache.stratos.manager.console/console/error.html
>>> components/org.apache.stratos.manager.console/console/er
>>> index c4436ec..c562b1c 100644
>>> --- components/org.apache.stratos.manager.console/console/error.html
>>> +++ components/org.apache.stratos.manager.console/console/error.html
>>> @@ -67,7 +67,7 @@
>>> <div class="container">
>>> <div class="row">
>>> <div class="col-lg-12">
>>> - <a style="margin-top: 20px;display: inline-block"
>>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>>> *+ <a style="margin-top: 20px;display: inline-block"
>>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>>
>>> <h1>OOPS!</h1>
>>> </div>
>>>
>>>
>>>
>>>
>>> Regards,
>>> Chamila de Alwis
>>> Software Engineer | WSO2 | +94772207163
>>> Blog: code.chamiladealwis.com
>>>
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
Re: Link to /console from Error Page Logo instead of /
Posted by Chamila De Alwis <ch...@wso2.com>.
opened at https://issues.apache.org/jira/browse/STRATOS-760
Attached the patch file to the issue.
Regards,
Chamila de Alwis
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com
On Mon, Aug 25, 2014 at 2:33 PM, Nirmal Fernando <ni...@gmail.com>
wrote:
> +1.. thanks Chamila for the fix. Can you please create a jira and send a
> PR against that?
>
>
> On Mon, Aug 25, 2014 at 2:29 PM, Chamila De Alwis <ch...@wso2.com>
> wrote:
>
>> Hi,
>>
>> The logo of the error pages produced by Stratos Manager links to "/"
>> which gets redirected to "/carbon" and presents the user with Carbon
>> console. I think the correct approach is to link it to "/console" so that
>> the user will land back on where he/she was working.
>>
>> I attached the suggested fix.
>>
>>
>> diff --git
>> components/org.apache.stratos.manager.console/console/error-404.html
>> components/org.apache.stratos.manager.console/consol
>> index 71ad847..5f121d0 100644
>> --- components/org.apache.stratos.manager.console/console/error-404.html
>> +++ components/org.apache.stratos.manager.console/console/error-404.html
>> @@ -67,7 +67,7 @@
>> <div class="container">
>> <div class="row">
>> <div class="col-lg-12">
>> - <a style="margin-top: 20px;display: inline-block"
>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>> *+ <a style="margin-top: 20px;display: inline-block"
>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>
>> <h1>OOPS!</h1>
>> </div>
>> diff --git
>> components/org.apache.stratos.manager.console/console/error.html
>> components/org.apache.stratos.manager.console/console/er
>> index c4436ec..c562b1c 100644
>> --- components/org.apache.stratos.manager.console/console/error.html
>> +++ components/org.apache.stratos.manager.console/console/error.html
>> @@ -67,7 +67,7 @@
>> <div class="container">
>> <div class="row">
>> <div class="col-lg-12">
>> - <a style="margin-top: 20px;display: inline-block"
>> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
>> *+ <a style="margin-top: 20px;display: inline-block"
>> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>>
>> <h1>OOPS!</h1>
>> </div>
>>
>>
>>
>>
>> Regards,
>> Chamila de Alwis
>> Software Engineer | WSO2 | +94772207163
>> Blog: code.chamiladealwis.com
>>
>>
>>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
Re: Link to /console from Error Page Logo instead of /
Posted by Nirmal Fernando <ni...@gmail.com>.
+1.. thanks Chamila for the fix. Can you please create a jira and send a PR
against that?
On Mon, Aug 25, 2014 at 2:29 PM, Chamila De Alwis <ch...@wso2.com> wrote:
> Hi,
>
> The logo of the error pages produced by Stratos Manager links to "/" which
> gets redirected to "/carbon" and presents the user with Carbon console. I
> think the correct approach is to link it to "/console" so that the user
> will land back on where he/she was working.
>
> I attached the suggested fix.
>
>
> diff --git
> components/org.apache.stratos.manager.console/console/error-404.html
> components/org.apache.stratos.manager.console/consol
> index 71ad847..5f121d0 100644
> --- components/org.apache.stratos.manager.console/console/error-404.html
> +++ components/org.apache.stratos.manager.console/console/error-404.html
> @@ -67,7 +67,7 @@
> <div class="container">
> <div class="row">
> <div class="col-lg-12">
> - <a style="margin-top: 20px;display: inline-block"
> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
> *+ <a style="margin-top: 20px;display: inline-block"
> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>
> <h1>OOPS!</h1>
> </div>
> diff --git
> components/org.apache.stratos.manager.console/console/error.html
> components/org.apache.stratos.manager.console/console/er
> index c4436ec..c562b1c 100644
> --- components/org.apache.stratos.manager.console/console/error.html
> +++ components/org.apache.stratos.manager.console/console/error.html
> @@ -67,7 +67,7 @@
> <div class="container">
> <div class="row">
> <div class="col-lg-12">
> - <a style="margin-top: 20px;display: inline-block"
> href="/"><img src="themes/theme1/ui/img/logo-login.png"/></a>
> *+ <a style="margin-top: 20px;display: inline-block"
> href="/console"><img src="themes/theme1/ui/img/logo-login.png"/>*
>
> <h1>OOPS!</h1>
> </div>
>
>
>
>
> Regards,
> Chamila de Alwis
> Software Engineer | WSO2 | +94772207163
> Blog: code.chamiladealwis.com
>
>
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/