You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/08/12 11:29:03 UTC

Review Request 37389: Ambari Server schema upgrade should prompt about backups

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37389/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-12730
    https://issues.apache.org/jira/browse/AMBARI-12730


Repository: ambari


Description
-------

When users perform "ambari-server upgrade", we should prompt the user to confirm they have backed-up the Ambari DB and Ambari .properties file before proceeding. User runs "ambari-server upgrade"...what do you think about this flow + output?

{code}
Performing ambari-server schema upgrade...
Confirm you have made a backup of /etc/ambari-server/conf/ambari.properties [y/n] (y)? 
Ambari Server configured for Embedded Postgres. Confirm you have made a backup of the Ambari Server database  [y/n] (y)? 
{code}

In the above, replace Embedded Postgres with Existing Postgres, Existing MySQL or Existing Oracle as appropriate.


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverConfiguration.py d9fc0ba 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a4fa24e 
  ambari-server/src/test/python/TestAmbariServer.py ee07597 

Diff: https://reviews.apache.org/r/37389/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 37389: Ambari Server schema upgrade should prompt about backups

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37389/#review95070
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Авг. 12, 2015, 9:29 д.п., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37389/
> -----------------------------------------------------------
> 
> (Updated Авг. 12, 2015, 9:29 д.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-12730
>     https://issues.apache.org/jira/browse/AMBARI-12730
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When users perform "ambari-server upgrade", we should prompt the user to confirm they have backed-up the Ambari DB and Ambari .properties file before proceeding. User runs "ambari-server upgrade"...what do you think about this flow + output?
> 
> {code}
> Performing ambari-server schema upgrade...
> Confirm you have made a backup of /etc/ambari-server/conf/ambari.properties [y/n] (y)? 
> Ambari Server configured for Embedded Postgres. Confirm you have made a backup of the Ambari Server database  [y/n] (y)? 
> {code}
> 
> In the above, replace Embedded Postgres with Existing Postgres, Existing MySQL or Existing Oracle as appropriate.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py d9fc0ba 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a4fa24e 
>   ambari-server/src/test/python/TestAmbariServer.py ee07597 
> 
> Diff: https://reviews.apache.org/r/37389/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>