You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2023/08/10 10:12:56 UTC

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20340


Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................

IMPALA-12359: Add missing package-info file used by HiveVersionInfo

We create a minimal-impala-hive-exec.jar based on Hive's hive-exec.jar:
https://github.com/apache/impala/blob/master/java/shaded-deps/hive-exec/pom.xml#L34

This excludes lots of class files, including
org/apache/hive/common/package-info.class that is used by
HiveVersionAnnotation and HiveVersionInfo classes.

Because of this HiveVersionInfo returns "Unknown" version resulting
in failing Iceberg operations.

Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
---
M java/shaded-deps/hive-exec/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/20340/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9586/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 15:54:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9589/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Aug 2023 07:14:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9584/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Aug 2023 11:34:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9588/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 21:43:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 21:43:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13735/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Aug 2023 10:40:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9584/


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 15:49:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20340

to look at the new patch set (#2).

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................

IMPALA-12359: Add missing package-info file used by HiveVersionInfo

We create a minimal-impala-hive-exec.jar based on Hive's hive-exec.jar:
https://github.com/apache/impala/blob/master/java/shaded-deps/hive-exec/pom.xml#L34

This excludes lots of class files, including
org/apache/hive/common/package-info.class that is used by
HiveVersionAnnotation and HiveVersionInfo classes.

Because of this HiveVersionInfo returns "Unknown" version resulting
in failing Iceberg operations.

Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
---
M java/shaded-deps/hive-exec/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/20340/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13736/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Aug 2023 10:42:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Aug 2023 11:28:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2: Code-Review+2

Thanks for the fix, Zoltan! LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 15:05:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9586/


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 10 Aug 2023 20:13:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................

IMPALA-12359: Add missing package-info file used by HiveVersionInfo

We create a minimal-impala-hive-exec.jar based on Hive's hive-exec.jar:
https://github.com/apache/impala/blob/master/java/shaded-deps/hive-exec/pom.xml#L34

This excludes lots of class files, including
org/apache/hive/common/package-info.class that is used by
HiveVersionAnnotation and HiveVersionInfo classes.

Because of this HiveVersionInfo returns "Unknown" version resulting
in failing Iceberg operations.

Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Reviewed-on: http://gerrit.cloudera.org:8080/20340
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M java/shaded-deps/hive-exec/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-12359: Add missing package-info file used by HiveVersionInfo

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20340 )

Change subject: IMPALA-12359: Add missing package-info file used by HiveVersionInfo
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9588/


-- 
To view, visit http://gerrit.cloudera.org:8080/20340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I444330a654d7d86e653588eb91d2f063d5be8c08
Gerrit-Change-Number: 20340
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Aug 2023 02:01:01 +0000
Gerrit-HasComments: No