[GitHub] [hbase] openinx commented on a change in pull request #301: HBASE-22547 Align the config keys and add document for offheap read in HBase Book.

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #301: HBASE-22547 Align the config keys and add document for offheap read in HBase Book.
URL: https://github.com/apache/hbase/pull/301#discussion_r295719959
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java
 ##########
 @@ -68,10 +68,18 @@
   // default heap allocator, it will just allocate ByteBuffers from heap but wrapped by an ByteBuff.
   public static final ByteBuffAllocator HEAP = ByteBuffAllocator.createOnHeap();
 
+  public static final String ALLOCATOR_ENABLED_KEY = "hbase.server.allocator.enabled";
 
 Review comment:
   Sorry for the confusing, my fault.  let's define the 4 new config keys as: 
   
   ```
   1. hbase.server.allocator.enabled -> hbase.server.allocator.pool.enabled
   2. hbase.server.reservoir.minimal.allocating.size -> hbase.server.allocator.minimal.allocate.size
   3. hbase.server.allocator.max.buffer.count
   4. hbase.server.allocator.buffer.size
   ```
   Will change all plances.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services