[jira] [Commented] (HDFS-17878) Reduce frequency of getDatanodeListForReport calls for metrics

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055373#comment-18055373 ] 

ASF GitHub Bot commented on HDFS-17878:
---------------------------------------

kokonguyen191 opened a new pull request, #8220:
URL: https://github.com/apache/hadoop/pull/8220

   ### Description of PR
   
   `getDatanodeListForReport` is called by a lot of metrics method while holding synchronized lock, interfering with more critical ops like datanodeReport while not having critical data (metrics). Best to reduce the frequency of calls to this method. This patch added a configurable cache that is force-wiped when there is a change in DNs, else expires using the configured expiration period.
   
   ### How was this patch tested?
   
   Product cluster + local UT benchmark




> Reduce frequency of getDatanodeListForReport calls for metrics
> --------------------------------------------------------------
>
>                 Key: HDFS-17878
>                 URL: https://issues.apache.org/jira/browse/HDFS-17878
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Felix N
>            Assignee: Felix N
>            Priority: Minor
>
> getDatanodeListForReport is called by a lot of metrics method while holding synchronized lock, interfering with more critical ops like datanodeReport while not having critical data (metrics). Best to reduce the frequency of calls to this method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org