You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:25:19 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #5311: Add RuntimeContext.getRules()

terrymanu opened a new pull request #5311:
URL: https://github.com/apache/shardingsphere/pull/5311


   For #3691


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #5311: Add RuntimeContext.getRules()

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #5311:
URL: https://github.com/apache/shardingsphere/pull/5311#issuecomment-619399155


   ## Pull Request Test Coverage Report for [Build 11242](https://coveralls.io/builds/30338437)
   
   * **36** of **46**   **(78.26%)**  changed or added relevant lines in **15** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.0007%**) to **57.239%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/30338437/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L397) | 0 | 1 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/PreparedStatementExecutor.java](https://coveralls.io/builds/30338437/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FPreparedStatementExecutor.java#L184) | 6 | 7 | 85.71%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/ShardingResultSetMetaData.java](https://coveralls.io/builds/30338437/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FShardingResultSetMetaData.java#L125) | 0 | 1 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/StatementExecutor.java](https://coveralls.io/builds/30338437/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FStatementExecutor.java#L172) | 5 | 7 | 71.43%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/30338437/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L359) | 6 | 8 | 75.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/30338437/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L103) | 1 | 4 | 25.0%
   <!-- | **Total:** | **36** | **46** | **78.26%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30338437/badge)](https://coveralls.io/builds/30338437) |
   | :-- | --: |
   | Change from base [Build 11241](https://coveralls.io/builds/30318418): |  0.0007% |
   | Covered Lines: | 11900 |
   | Relevant Lines: | 20790 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #5311: Add RuntimeContext.getRules()

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #5311:
URL: https://github.com/apache/shardingsphere/pull/5311#issuecomment-619398810


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=h1) Report
   > Merging [#5311](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3c5f42972ab56a4d08b2c9407bd3e453d6b3914c&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `69.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5311/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5311      +/-   ##
   ============================================
   + Coverage     53.69%   53.70%   +0.01%     
     Complexity      413      413              
   ============================================
     Files          1163     1163              
     Lines         20792    20790       -2     
     Branches       3766     3762       -4     
   ============================================
   + Hits          11164    11166       +2     
   + Misses         8904     8903       -1     
   + Partials        724      721       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `72.72% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/jdbc/core/context/AbstractRuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9BYnN0cmFjdFJ1bnRpbWVDb250ZXh0LmphdmE=) | `93.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../jdbc/core/context/impl/EncryptRuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9pbXBsL0VuY3J5cHRSdW50aW1lQ29udGV4dC5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...c/core/context/impl/MasterSlaveRuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9pbXBsL01hc3RlclNsYXZlUnVudGltZUNvbnRleHQuamF2YQ==) | `85.71% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/jdbc/core/context/impl/ShadowRuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9pbXBsL1NoYWRvd1J1bnRpbWVDb250ZXh0LmphdmE=) | `60.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/context/impl/ShardingRuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9pbXBsL1NoYXJkaW5nUnVudGltZUNvbnRleHQuamF2YQ==) | `92.30% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/resultset/ShardingResultSetMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/core/statement/MasterSlavePreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L01hc3RlclNsYXZlUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `19.09% <25.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/resultset/DatabaseMetaDataResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0RhdGFiYXNlTWV0YURhdGFSZXN1bHRTZXQuamF2YQ==) | `97.54% <50.00%> (+0.81%)` | `1.00 <0.00> (ø)` | |
   | [...phere/shardingjdbc/executor/StatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9TdGF0ZW1lbnRFeGVjdXRvci5qYXZh) | `80.00% <57.14%> (+0.33%)` | `1.00 <0.00> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/5311/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=footer). Last update [3c5f429...0f0ac5f](https://codecov.io/gh/apache/shardingsphere/pull/5311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org