You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by taozle <gi...@git.apache.org> on 2017/07/23 13:24:38 UTC
[GitHub] thrift pull request #1312: Add context as first arg for client method.
GitHub user taozle opened a pull request:
https://github.com/apache/thrift/pull/1312
Add context as first arg for client method.
Related: https://issues.apache.org/jira/browse/THRIFT-4260
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taozle/thrift client-context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1312
----
commit 202840379f99e5cdf786b1a4ac698b1cf40ede12
Author: taozle <zh...@gmail.com>
Date: 2017-07-23T13:21:44Z
Add context as first arg for client method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.
Posted by domino14 <gi...@git.apache.org>.
Github user domino14 commented on the issue:
https://github.com/apache/thrift/pull/1312
Is this in the latest version of thrift? It seems that auto-generated code does not have `context` in its function signatures, but thrift itself requires them, so auto-generated code does not compile with the version of thrift that generated it!
---
[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1312
LGTM (once again, travis failure is unrelated)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1312: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
Github user taozle closed the pull request at:
https://github.com/apache/thrift/pull/1312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1312: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
Github user taozle closed the pull request at:
https://github.com/apache/thrift/pull/1312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1312: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
Github user taozle commented on the issue:
https://github.com/apache/thrift/pull/1312
@dcelasun @Jens-G PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1312: Add context as first arg for client method.
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1312
Travis failures seem unrelated.
cc @Jens-G
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
Github user taozle commented on the issue:
https://github.com/apache/thrift/pull/1312
You must use the generator compiled from the master branch.
---
[GitHub] thrift pull request #1312: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
GitHub user taozle reopened a pull request:
https://github.com/apache/thrift/pull/1312
Add context as first arg for client method.
Related: https://issues.apache.org/jira/browse/THRIFT-4260
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taozle/thrift client-context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1312
----
commit 202840379f99e5cdf786b1a4ac698b1cf40ede12
Author: taozle <zh...@gmail.com>
Date: 2017-07-23T13:21:44Z
Add context as first arg for client method.
commit 9ea932aac18735cdd0579b65b259a5b9162d5347
Author: taozle <zh...@gmail.com>
Date: 2017-07-23T17:44:28Z
Fix tests.
commit ab761b61a3b87affa5bead0d8ba662e2efdbafa3
Author: taozle <zh...@gmail.com>
Date: 2017-07-24T03:20:30Z
Fix tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1312: THRIFT-4260: Add context as first arg for client ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1312: Add context as first arg for client method.
Posted by taozle <gi...@git.apache.org>.
GitHub user taozle reopened a pull request:
https://github.com/apache/thrift/pull/1312
Add context as first arg for client method.
Related: https://issues.apache.org/jira/browse/THRIFT-4260
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taozle/thrift client-context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1312
----
commit 202840379f99e5cdf786b1a4ac698b1cf40ede12
Author: taozle <zh...@gmail.com>
Date: 2017-07-23T13:21:44Z
Add context as first arg for client method.
commit 9ea932aac18735cdd0579b65b259a5b9162d5347
Author: taozle <zh...@gmail.com>
Date: 2017-07-23T17:44:28Z
Fix tests.
commit ab761b61a3b87affa5bead0d8ba662e2efdbafa3
Author: taozle <zh...@gmail.com>
Date: 2017-07-24T03:20:30Z
Fix tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---