You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ni...@apache.org on 2016/02/19 19:31:24 UTC
[6/7] samza git commit: SAMZA-836: Fix rocksdb unit test failure
SAMZA-836: Fix rocksdb unit test failure
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/4bcf88f5
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/4bcf88f5
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/4bcf88f5
Branch: refs/heads/samza-sql
Commit: 4bcf88f5e38ed18ff485a29fa6a472a922c0900d
Parents: 2176430
Author: Yi Pan <ni...@gmail.com>
Authored: Fri Feb 12 17:29:22 2016 -0800
Committer: Yi Pan (Data Infrastructure) <ni...@gmail.com>
Committed: Fri Feb 12 17:29:22 2016 -0800
----------------------------------------------------------------------
.../samza/storage/kv/TestRocksDbKeyValueStore.scala | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/4bcf88f5/samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
----------------------------------------------------------------------
diff --git a/samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b/samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
index 0c86a5a..b7f1cdc 100644
--- a/samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
+++ b/samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
@@ -23,14 +23,10 @@ package org.apache.samza.storage.kv
import java.io.File
import java.util
-import org.apache.samza.{SamzaException, Partition}
import org.apache.samza.config.MapConfig
-import org.apache.samza.container.{TaskName, SamzaContainerContext}
-import org.apache.samza.system.SystemStreamPartition
-import org.apache.samza.util.{NoOpMetricsRegistry, ExponentialSleepStrategy}
-import org.apache.samza.util.Util._
+import org.apache.samza.util.ExponentialSleepStrategy
import org.junit.{Assert, Test}
-import org.rocksdb.{RocksDB, FlushOptions, RocksDBException, Options}
+import org.rocksdb.{RocksDB, FlushOptions, Options}
class TestRocksDbKeyValueStore
{
@@ -70,7 +66,6 @@ class TestRocksDbKeyValueStore
def testFlush(): Unit = {
val map = new util.HashMap[String, String]()
val config = new MapConfig(map)
- val flushOptions = new FlushOptions().setWaitForFlush(true)
val options = new Options()
options.setCreateIfMissing(true)
val rocksDB = RocksDbKeyValueStore.openDB(new File(System.getProperty("java.io.tmpdir")),
@@ -80,6 +75,9 @@ class TestRocksDbKeyValueStore
"dbStore")
val key = "key".getBytes("UTF-8")
rocksDB.put(key, "val".getBytes("UTF-8"))
+ // SAMZA-836: Mysteriously,calling new FlushOptions() does not invoke the NativeLibraryLoader in rocksdbjni-3.13.1!
+ // Moving this line after calling new Options() resolve the issue.
+ val flushOptions = new FlushOptions().setWaitForFlush(true)
rocksDB.flush(flushOptions)
val dbDir = new File(System.getProperty("java.io.tmpdir")).toString
val rocksDBReadOnly = RocksDB.openReadOnly(options, dbDir)