You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/03/17 16:35:29 UTC

[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introducing project.topdir

gnodet commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1474103158

   > Do these three properties represent the same value?
   
   I suppose you're talking about `topdir`, `project.topdir` and `session.topdir` ? They are aliases, but I don't think the `project.topdir` is a good idea, since it's not really a project attribute.
   
   I'm still thinking about renaming the new property to `rootdir`, and introduce a `topdir` for the execution directory in a consistent way.  And deprecate `MavenSession.getExecutionRootDirectory()`, `MavenExecutionRequest.getBasedir()`, `MavenExecutionRequest.getMultiModuleProjectDirectory()` accordingly.  I'm open to any naming, but things are a bit inconsistent, so I'd rather fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org