You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/12 16:39:13 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24046: chore(security): Make get_database_perm/get_dataset_perm return optional
codecov[bot] commented on PR #24046:
URL: https://github.com/apache/superset/pull/24046#issuecomment-1546011002
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24046](https://app.codecov.io/gh/apache/superset/pull/24046?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2797a63) into [master](https://app.codecov.io/gh/apache/superset/commit/97482c57b55c7bc79d923968cdfc06accd9b6788?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (97482c5) will **decrease** coverage by `11.24%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #24046 +/- ##
===========================================
- Coverage 68.22% 56.98% -11.24%
===========================================
Files 1941 1941
Lines 75261 75261
Branches 8168 8168
===========================================
- Hits 51344 42888 -8456
- Misses 21828 30284 +8456
Partials 2089 2089
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.18% <100.00%> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.10% <100.00%> (ø)` | |
| python | `59.60% <100.00%> (-23.19%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.05% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/24046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `62.10% <100.00%> (-33.87%)` | :arrow_down: |
... and [307 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24046/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org