You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:16:43 UTC

[GitHub] [skywalking-rust] jmjoy opened a new pull request, #47: Fix trace id is not transmitted.

jmjoy opened a new pull request, #47:
URL: https://github.com/apache/skywalking-rust/pull/47

   In cross process scenes, the trace id is not transmitted, by mistake in the previous modification (https://github.com/apache/skywalking-rust/pull/39#issuecomment-1202186488).
   
   The e2e is not coverd, because it dost not record trace id field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] wu-sheng commented on pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47#issuecomment-1228308810

   I added this to closed 0.4.0 release. Please notice to delete 0.4 tag carefully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] wu-sheng merged pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] codecov-commenter commented on pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47#issuecomment-1228277634

   # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/47?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#47](https://codecov.io/gh/apache/skywalking-rust/pull/47?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (152a2ce) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/49f6d76e65df0c491fcefd5848802c27f9baf6d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49f6d76) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master      #47      +/-   ##
   ==========================================
   - Coverage   22.16%   22.12%   -0.04%     
   ==========================================
     Files          18       18              
     Lines         591      592       +1     
   ==========================================
     Hits          131      131              
   - Misses        460      461       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [src/trace/trace\_context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3RyYWNlX2NvbnRleHQucnM=) | `24.32% <0.00%> (-0.17%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] wu-sheng commented on pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47#issuecomment-1228283616

   So, would you like to cancel the on going release vote? This seems a critical bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] jmjoy commented on pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47#issuecomment-1228292128

   > So, would you like to cancel the on going release vote? This seems a critical bug.
   
   I think so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-rust] jmjoy commented on pull request #47: Fix trace id is not transmitted.

Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #47:
URL: https://github.com/apache/skywalking-rust/pull/47#issuecomment-1228673511

   The 0.4.0 tag will be set to the latest commit, if the PR is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org