You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2015/12/18 21:00:09 UTC
Review Request 41565: Improve review_feedback.py testability.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Support host-or-base-url for easier local non-https testing.
Don't require a defaulted arg and don't require --git-clean-excludes.
build-support/jenkins/review_feedback.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Diffs
-----
build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e
Diff: https://reviews.apache.org/r/41565/diff/
Testing
-------
Locally against a local RB install:
```
$ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
Request: http://localhost:8888/api/repositories/?name=aurora
Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
Found 1 review requests to inspect
Inspecting review 2: Support host-or-base-url for easier local non-https testing.
Request: http://localhost:8888/api/review-requests/2/reviews/
Request: http://localhost:8888/api/review-requests/2/diffs/
Latest feedback was given at 2015-12-16T18:50:13Z
Latest build request from a user at 2015-12-16T18:50:13Z
Latest diff was posted at 2015-12-16T18:49:55Z
```
Thanks,
John Sirois
Re: Review Request 41565: Improve review_feedback.py testability.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 18, 2015, 1:13 p.m., Aurora ReviewBot wrote:
> > Master (1c73438) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Bill - I'm ignorant of the Jenkins setup - is this using my changes live or is a special deploy step needed to use `review_feedback.py` edits?
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111257
-----------------------------------------------------------
On Dec. 18, 2015, 1 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
>
> build-support/jenkins/review_feedback.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e
>
> Diff: https://reviews.apache.org/r/41565/diff/
>
>
> Testing
> -------
>
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
> Request: http://localhost:8888/api/repositories/?name=aurora
> Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https testing.
> Request: http://localhost:8888/api/review-requests/2/reviews/
> Request: http://localhost:8888/api/review-requests/2/diffs/
> Latest feedback was given at 2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at 2015-12-16T18:49:55Z
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41565: Improve review_feedback.py testability.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 18, 2015, 12:13 p.m., Aurora ReviewBot wrote:
> > Master (1c73438) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
>
> John Sirois wrote:
> Bill - I'm ignorant of the Jenkins setup - is this using my changes live or is a special deploy step needed to use `review_feedback.py` edits?
It was not used in this review run, but will be used from master in subsequent runs.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111257
-----------------------------------------------------------
On Dec. 18, 2015, noon, John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, noon)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
>
> build-support/jenkins/review_feedback.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e
>
> Diff: https://reviews.apache.org/r/41565/diff/
>
>
> Testing
> -------
>
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
> Request: http://localhost:8888/api/repositories/?name=aurora
> Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https testing.
> Request: http://localhost:8888/api/review-requests/2/reviews/
> Request: http://localhost:8888/api/review-requests/2/diffs/
> Latest feedback was given at 2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at 2015-12-16T18:49:55Z
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41565: Improve review_feedback.py testability.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111257
-----------------------------------------------------------
Ship it!
Master (1c73438) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 18, 2015, 8 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 8 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
>
> build-support/jenkins/review_feedback.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e
>
> Diff: https://reviews.apache.org/r/41565/diff/
>
>
> Testing
> -------
>
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
> Request: http://localhost:8888/api/repositories/?name=aurora
> Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https testing.
> Request: http://localhost:8888/api/review-requests/2/reviews/
> Request: http://localhost:8888/api/review-requests/2/diffs/
> Latest feedback was given at 2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at 2015-12-16T18:49:55Z
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41565: Improve review_feedback.py testability.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111259
-----------------------------------------------------------
Ship it!
- Bill Farner
On Dec. 18, 2015, noon, John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, noon)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
>
> build-support/jenkins/review_feedback.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e
>
> Diff: https://reviews.apache.org/r/41565/diff/
>
>
> Testing
> -------
>
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
> Request: http://localhost:8888/api/repositories/?name=aurora
> Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https testing.
> Request: http://localhost:8888/api/review-requests/2/reviews/
> Request: http://localhost:8888/api/review-requests/2/diffs/
> Latest feedback was given at 2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at 2015-12-16T18:49:55Z
> ```
>
>
> Thanks,
>
> John Sirois
>
>