You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/07/25 14:08:41 UTC
[PR] Skip SLA miss callback when in DB isolation mode [airflow]
potiuk opened a new pull request, #41028:
URL: https://github.com/apache/airflow/pull/41028
This PR disables SLA miss callback for DB isolation mode because it would require quite a havy refactoring (or rather rewriting from the scratch). Currently SLA miss calculation heavily depends on the fact that both - DB is available and DAG code is parsed
- basically that we have DAG object in memory that has the logic that allows to calculate SLA misses while querying Airflow DB multiple times. It's likely possible to unentangle it and make the logic separate from the DAG object, but it's not really good idea to do it now. It's better to disable it.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip SLA miss callback when in DB isolation mode [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41028:
URL: https://github.com/apache/airflow/pull/41028#issuecomment-2250519820
I updated it to use markers rather than fixtures (which is way more standard). Also removed typehint that I added for get_dag() for dagbag. Now I know why dagbag.get_dag() does not have type defined (because it is sometimes treated as DAG and sometimes as DAGModel and sometimes there is no assumption it might be None. But I am not going to fix it now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip SLA miss callback when in DB isolation mode [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #41028:
URL: https://github.com/apache/airflow/pull/41028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip SLA miss callback when in DB isolation mode [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41028:
URL: https://github.com/apache/airflow/pull/41028#issuecomment-2250426387
I attempted to see what it would mean to make `manage_sla` to work with isolation mode and it's definitely not worth doing it now (especially that we know that SLA is broken in Airflow) - we will have to fix it in AIP-72 - but there the whole discussion on "where callbacks should run" is better aided by this one - because this is a good example where logic of "parsed dag" and "DB access" have to be together in the same process in order to calculate SLA missess - and they are very hard to separate out. This is something that must be considered for AIP-72 (cc: @ashb )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org