You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/07 20:12:28 UTC
[GitHub] [ignite] killergti opened a new pull request #9307: IGNITE-15256: ClassNotFoundException on attempt to invoke service met…
killergti opened a new pull request #9307:
URL: https://github.com/apache/ignite/pull/9307
…hod from Java ThinClient after cluster failover
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
killergti commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-908944125
@ptupitsyn just a friendly reminder. Could you please merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
killergti commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-901857531
> Please merge latest changes from `master`, then re-run the tests. There was a problem in master a few days ago that has been fixed, but it exists in this branch and causes test failures.
Hopefully it's done :) @ptupitsyn could you please verify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
killergti commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-899436037
> @killergti Looks good to me +1
>
> Please make sure TeamCity build is green (see comments in JIRA), and I'll merge the PR.
@ptupitsyn could you please clarify what task should I trigger? I've tried the "Run All" and it fails all the time. Not only does it fail in my branch, but it fails in all branches (as far as I can see).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9307: IGNITE-15256: ClassNotFoundException on attempt to invoke service met…
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#discussion_r687605685
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -125,6 +126,11 @@ private TcpIgniteClient(ClientConfiguration cfg) throws ClientException {
ch.channelsInit();
ch.addChannelFailListener(metadataHnd::onReconnect);
+ // Binary descriptors and user types caches must be cleared so that the
+ // client will register all the user types within the cluster once again in case this information
+ // was lost during the cluster failover.
+ ch.addChannelFailListener(marshCtx::clearUserTypesCache);
Review comment:
We can add use one fail listener to perform all tasks instead of adding three of them.
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java
##########
@@ -1437,6 +1440,7 @@ public void onUndeploy(ClassLoader ldr) {
it.remove();
}
}
+ optmMarsh.onUndeploy(ldr);
Review comment:
Missing blank line after the block.
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -125,6 +126,11 @@ private TcpIgniteClient(ClientConfiguration cfg) throws ClientException {
ch.channelsInit();
ch.addChannelFailListener(metadataHnd::onReconnect);
+ // Binary descriptors and user types caches must be cleared so that the
Review comment:
Missing blank line before the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on a change in pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
killergti commented on a change in pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#discussion_r687767263
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -125,6 +126,11 @@ private TcpIgniteClient(ClientConfiguration cfg) throws ClientException {
ch.channelsInit();
ch.addChannelFailListener(metadataHnd::onReconnect);
+ // Binary descriptors and user types caches must be cleared so that the
+ // client will register all the user types within the cluster once again in case this information
+ // was lost during the cluster failover.
+ ch.addChannelFailListener(marshCtx::clearUserTypesCache);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-898862532
@killergti Looks good to me :+1:
Please make sure TeamCity build is green (see comments in JIRA), and I'll merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-899459252
> > @killergti Looks good to me +1
> > Please make sure TeamCity build is green (see comments in JIRA), and I'll merge the PR.
>
> @ptupitsyn could you please clarify what task should I trigger? I've tried the "Run All" and it fails all the time. Not only does it fail in my branch, but it fails in all branches (as far as I can see).
There should be a green "TC Bot Visa" in the JIRA comments, see [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #9307:
URL: https://github.com/apache/ignite/pull/9307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #9307:
URL: https://github.com/apache/ignite/pull/9307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
killergti commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-908944125
@ptupitsyn just a friendly reminder. Could you please merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] killergti commented on pull request #9307: IGNITE-15256: ClassNotFoundException on attempt to invoke service met…
Posted by GitBox <gi...@apache.org>.
killergti commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-894702733
The root cause of the issue is that client believe that server nodes preserve the registered user types after reconnect, however, it could be the case that server nodes loose this information (e.g. full cluster restart with clean up of working dirs). This leads to ClassNotFoundException.
In the scope of this PR I have added code that clears the cache of registered Serializable and Externalizable classes (in the OptimizedMarshaller) when a client looses connection to the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-908981975
@killergti merged, sorry for the delay!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-899460819
Please merge latest changes from `master`, then re-run the tests. There was a problem in master a few days ago that has been fixed, but it exists in this branch and causes test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on pull request #9307: IGNITE-15256 Java Thin: Fix ClassNotFoundException on service call after failover
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#issuecomment-908981975
@killergti merged, sorry for the delay!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org