You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/01 20:16:09 UTC

[GitHub] [geode] ringles commented on a change in pull request #5973: GEODE-8885: move hincrby command to supported

ringles commented on a change in pull request #5973:
URL: https://github.com/apache/geode/pull/5973#discussion_r568102972



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHashesIntegrationTest.java
##########
@@ -48,6 +50,7 @@
   private Jedis jedis;
   private Jedis jedis2;
   private static int ITERATION_COUNT = 4000;
+  private static int NUM_ITERATIONS = 1000;

Review comment:
       Having a constant named "ITERATION_COUNT" right next to a constant named "NUM_ITERATIONS" feels weird. At least one of them should be renamed to be a bit more specific.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org