You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "gaozhangmin (via GitHub)" <gi...@apache.org> on 2023/08/28 03:17:51 UTC

[GitHub] [bookkeeper] gaozhangmin opened a new pull request, #4059: Fix readEntry parameter order

gaozhangmin opened a new pull request, #4059:
URL: https://github.com/apache/bookkeeper/pull/4059

   Correct the parameters order of method `readEntry`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] gaozhangmin commented on pull request #4059: Fix readEntry parameter order

Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin commented on PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059#issuecomment-1700938621

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #4059: Fix readEntry parameter order

Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on code in PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059#discussion_r1308458173


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/directentrylogger/TestDirectEntryLogger.java:
##########
@@ -200,7 +200,10 @@ public void close() throws IOException {
             }
             elog.flush();
             for (Long loc : locations) {
-                ReferenceCountUtil.release(elog.readEntry(loc));
+                int i = locations.indexOf(loc);

Review Comment:
   This test is for direct entry logger, it can't cover this fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] hangc0276 merged pull request #4059: Fix readEntry parameter order

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] gaozhangmin commented on pull request #4059: Fix readEntry parameter order

Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin commented on PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059#issuecomment-1695074885

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] gaozhangmin commented on pull request #4059: Fix readEntry parameter order

Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin commented on PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059#issuecomment-1695404964

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] gaozhangmin commented on a diff in pull request #4059: Fix readEntry parameter order

Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin commented on code in PR #4059:
URL: https://github.com/apache/bookkeeper/pull/4059#discussion_r1311273113


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/directentrylogger/TestDirectEntryLogger.java:
##########
@@ -200,7 +200,10 @@ public void close() throws IOException {
             }
             elog.flush();
             for (Long loc : locations) {
-                ReferenceCountUtil.release(elog.readEntry(loc));
+                int i = locations.indexOf(loc);

Review Comment:
   @horizonzy  Fixed Thx for pointing it out



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org