[GitHub] [kafka] mjsax commented on a diff in pull request #12020: MINOR: Add generation to consumer assignor logs

[GitBox <gi...@apache.org>]

mjsax commented on code in PR #12020:
URL: https://github.com/apache/kafka/pull/12020#discussion_r846536809


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -86,10 +87,23 @@
 import static org.apache.kafka.streams.processor.internals.assignment.StreamsAssignmentProtocolVersions.UNKNOWN;
 import static org.apache.kafka.streams.processor.internals.assignment.SubscriptionInfo.UNKNOWN_OFFSET_SUM;
 
-public class StreamsPartitionAssignor implements ConsumerPartitionAssignor, Configurable {
+public class StreamsPartitionAssignor implements ConsumerPartitionAssignor, Configurable,
+    ContextualLogging {

Review Comment:
   Isn't it a little weird that the assignor implement that contextual logging interface? It's an assignor, not a logger?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org