You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "WeichenXu123 (via GitHub)" <gi...@apache.org> on 2023/06/01 02:42:22 UTC

[GitHub] [spark] WeichenXu123 commented on pull request #41404: [SPARK-41593][FOLLOW-UP][ML] Torch distributor log streaming server: Avoid duplicated log to stdout redirection

WeichenXu123 commented on PR #41404:
URL: https://github.com/apache/spark/pull/41404#issuecomment-1571237500

   @HyukjinKwon Yes there's some 
   
   > I reran the tests but I think the failure is related.
   
   Yes test failed because the test checks the log server redirection output but test runs in spark local mode then the redirection in log server side is skipped.
   
   I changed the implementation that skip log STDOUT redirection in client side, then we don't need to change tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org