You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Scott Swank (JIRA)" <ji...@apache.org> on 2008/02/06 22:25:07 UTC
[jira] Created: (WICKET-1327) CompoundModel backed by cglib proxies
CompoundModel backed by cglib proxies
-------------------------------------
Key: WICKET-1327
URL: https://issues.apache.org/jira/browse/WICKET-1327
Project: Wicket
Issue Type: New Feature
Components: wicket
Reporter: Scott Swank
Priority: Minor
This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by Nick Heudecker <nh...@gmail.com>.
I'm definitely going to talk about it at TSSJS.
On Feb 6, 2008 4:57 PM, Martijn Dashorst <ma...@gmail.com> wrote:
> On 2/6/08, Eelco Hillenius <ee...@gmail.com> wrote:
> > Yeah, I saw it right after I posted the comment. I deleted it, but not
> > quick enough to avoid you getting the email :-)
> >
> > Interesting idea.
>
> Yeah, I'm going to see if this works in our project first thing
> tomorrow...
>
> I may even need to update WIA for this :)
>
> Martijn
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.0 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0
>
-Nick
Re: [jira] Commented: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by Martijn Dashorst <ma...@gmail.com>.
On 2/6/08, Eelco Hillenius <ee...@gmail.com> wrote:
> Yeah, I saw it right after I posted the comment. I deleted it, but not
> quick enough to avoid you getting the email :-)
>
> Interesting idea.
Yeah, I'm going to see if this works in our project first thing tomorrow...
I may even need to update WIA for this :)
Martijn
--
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.0 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0
Re: [jira] Commented: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by Eelco Hillenius <ee...@gmail.com>.
Yeah, I saw it right after I posted the comment. I deleted it, but not
quick enough to avoid you getting the email :-)
Interesting idea.
Eelco
On Feb 6, 2008 2:38 PM, Martijn Dashorst <ma...@gmail.com> wrote:
> This provides us with probably the holy grail for refactoring property
> expressions.
>
> This model uses the type inference of generics together with a proxy
> generator to bind to statically types property expressions.
>
> I think this is awesome: we don't have to wait for Java 7 for this.
>
> Martijn
>
> On 2/6/08, Eelco Hillenius (JIRA) <ji...@apache.org> wrote:
> >
> > [ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566370#action_12566370 ]
> >
> > Eelco Hillenius commented on WICKET-1327:
> > -----------------------------------------
> >
> > What is the advantage of doing this? A dramatic optimization?
> >
> > > CompoundModel backed by cglib proxies
> > > -------------------------------------
> > >
> > > Key: WICKET-1327
> > > URL: https://issues.apache.org/jira/browse/WICKET-1327
> > > Project: Wicket
> > > Issue Type: New Feature
> > > Components: wicket
> > > Reporter: Scott Swank
> > > Priority: Minor
> > > Fix For: 1.4-M1
> > >
> > > Attachments: Model.zip
> > >
> > >
> > > This is a simple model that lets cglib handle building the propertyExpression.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.0 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0
>
Re: [jira] Commented: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by Martijn Dashorst <ma...@gmail.com>.
This provides us with probably the holy grail for refactoring property
expressions.
This model uses the type inference of generics together with a proxy
generator to bind to statically types property expressions.
I think this is awesome: we don't have to wait for Java 7 for this.
Martijn
On 2/6/08, Eelco Hillenius (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566370#action_12566370 ]
>
> Eelco Hillenius commented on WICKET-1327:
> -----------------------------------------
>
> What is the advantage of doing this? A dramatic optimization?
>
> > CompoundModel backed by cglib proxies
> > -------------------------------------
> >
> > Key: WICKET-1327
> > URL: https://issues.apache.org/jira/browse/WICKET-1327
> > Project: Wicket
> > Issue Type: New Feature
> > Components: wicket
> > Reporter: Scott Swank
> > Priority: Minor
> > Fix For: 1.4-M1
> >
> > Attachments: Model.zip
> >
> >
> > This is a simple model that lets cglib handle building the propertyExpression.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.0 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566393#action_12566393 ]
Frank Bille Jensen commented on WICKET-1327:
--------------------------------------------
Only having looked briefly at it, it looks quite cool. I'm all for putting in extensions to begin with until we know what to do with it. And I wouldn't be against replacing property model and friends with this if it proves to be same performance and that users like it.
How will it handle expressions like these (this is what property resolver handles atm):
"property1.property2"
"mylist.0"
"property[key]"
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1327:
----------------------------------
Fix Version/s: 1.4-M1
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Blake Minghelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566695#action_12566695 ]
Blake Minghelli commented on WICKET-1327:
-----------------------------------------
Scott Swank posted this model implementation on my behalf. Please accept this as authorization to treat this as an open contribution to Wicket.
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1327:
----------------------------------
Fix Version/s: 1.5-M3
(was: 1.5-M2)
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.5-M3
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-1327:
------------------------------------
Comment: was deleted
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566398#action_12566398 ]
Igor Vaynberg commented on WICKET-1327:
---------------------------------------
property1.property2 should be no problem considering there are getProperty1() that returns an object which has getProperty2(), this is handled by a simple builder pattern where getProperty1() returns a builder proxy of object that has getProperty2() and keeps context.
mylist.0 will be tricky for arrays, not sure if we can intercept myarray[5].getfoo(). we can intercept getfoo() obviously, but myarray[5]?
property[key] should also be ok, the builderproxy returned for set or map can keep track of get calls.
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1327:
---------------------------------------
Fix Version/s: (was: 1.4-M1)
1.4-M2
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.4-M2
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Scott Swank (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Swank updated WICKET-1327:
--------------------------------
Attachment: Model.zip
Proof of concept implementation.
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566370#action_12566370 ]
Eelco Hillenius commented on WICKET-1327:
-----------------------------------------
What is the advantage of doing this? A dramatic optimization?
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1327:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.5-M2
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Scott Swank (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572570#action_12572570 ]
Scott Swank commented on WICKET-1327:
-------------------------------------
Because the ExpressionBuilder has a cglib proxy it is not Serializable. This means that we want to evaluate the expression and serialize the resulting String. Because we don't know when the recording is complete, we need to hook into the jvm's serialization process via writeObject() to ensure that we have a String instead of an ExpressionBuilder.
String getPropertyExpression()
{
// If not yet evaluated, then do so now and then
// discard the expression builder since it is no longer useful
// and is not Serializable
if (propertyExpression == null)
{
propertyExpression = expressionBuilder.eval();
expressionBuilder = null;
}
return propertyExpression;
}
private void writeObject(ObjectOutputStream out) throws IOException
{
// PropertyExpressionBuilder is not serializable, but the String it
// generates is. Hence we must call getPropertyExpression() before
// serialization.
getPropertyExpression();
out.defaultWriteObject();
}
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566373#action_12566373 ]
Igor Vaynberg commented on WICKET-1327:
---------------------------------------
if we start going down this road we can also have an alternative property resolver that generates bytecode to directly access fields instead of reflection. maybe put this into wicket-something.
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1327:
------------------------------------
Fix Version/s: (was: 1.4-M2)
1.5-M1
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.5-M1
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1327:
------------------------------------
Attachment: matej_and_johan_great_work_in_thailand.jar
with this attachement you can do this:
SafePropertyModel<Person> p = new SafePropertyModel<Person>(new Person());
TextField field = new TextField("name", p.bind(p.property().getFirstName()));
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572615#action_12572615 ]
James Carman commented on WICKET-1327:
--------------------------------------
Would you be willing to implement this using Apache Commons Proxy? It would take all of the proxying logic (CGLIB stuff) out of your code and it would also allow you (or the user) to switch proxying technologies altogether. Let me know if you want an example.
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1327) CompoundModel backed by cglib
proxies
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-1327:
---------------------------------------
Assignee: Johan Compagner
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.4-M1
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1327) CompoundModel backed by cglib proxies
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-1327:
-------------------------------------
Fix Version/s: (was: 1.5-M3)
1.5-M4
> CompoundModel backed by cglib proxies
> -------------------------------------
>
> Key: WICKET-1327
> URL: https://issues.apache.org/jira/browse/WICKET-1327
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Scott Swank
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.5-M4
>
> Attachments: matej_and_johan_great_work_in_thailand.jar, Model.zip
>
>
> This is a simple model that lets cglib handle building the propertyExpression.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.