[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

[vladimir-kotikov <gi...@git.apache.org>]

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695102
  
    --- Diff: lib/PluginsManager.js ---
    @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () {
         installedPlugins.forEach(function(plugin) {
             // there is test plugin available
             if (fs.existsSync(path.join(plugin.dir, 'tests', 'plugin.xml'))) {
    -            me.installSinglePlugin(path.join(plugin.dir, 'tests'));
    +            var additionalArgs = '';
    +            if (plugin.id.indexOf('cordova-plugin-file-transfer') >= 0) {
    +                var fileServerUrl = Server.prototype.getConnectionAddress.bind({
    --- End diff --
    
    Can we just create a new `Server()` and call `getConnectionAddress` on the instance instead? IMO this seems to be more intuitive than using `bind`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org