[GitHub] [netbeans] mbien commented on a diff in pull request #5317: code cleanup - no logic changes

[GitBox <gi...@apache.org>]

mbien commented on code in PR #5317:
URL: https://github.com/apache/netbeans/pull/5317#discussion_r1082408930


##########
harness/o.n.insane/src/org/netbeans/insane/model/BinaryHeapModel.java:
##########
@@ -49,7 +49,7 @@ public static HeapModel open(File file) throws Exception {
         // mmap it
         long len = data.length();
         buffer = new FileInputStream(data).getChannel().map(FileChannel.MapMode.READ_ONLY, 0, len);
-        System.err.println("magic=" + buffer.getInt(0));
+        System.err.println("magic=" + buffer.getInt(0)); // shouldn't this be replaced with logging statement?

Review Comment:
   completely changing the logging mechanism of a module is out of scope of PRs which do simple language level cleanup. The title says no logic changes.
   
   If you want to annotate your code in temporary manner, use the github review feature. This feature was made for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists