You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "himanshukandwal (via GitHub)" <gi...@apache.org> on 2023/08/24 04:22:21 UTC
[GitHub] [helix] himanshukandwal commented on a diff in pull request #2607: Add method to create full key path if it does not exist
himanshukandwal commented on code in PR #2607:
URL: https://github.com/apache/helix/pull/2607#discussion_r1303632684
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -115,6 +117,41 @@ public void create(String key, Object data, MetaClientInterface.EntryMode mode)
}
}
+ @Override
+ public void recursiveCreate(String key, T data, EntryMode mode) {
+ recursiveCreateHelper(key, data, mode, -1);
+ }
+
+ @Override
+ public void recursiveCreateWithTTL(String key, T data, long ttl) {
+ recursiveCreateHelper(key, data, EntryMode.TTL, ttl);
+ }
+
+ private void recursiveCreateHelper(String key, T data, EntryMode mode, long ttl) {
+ boolean retry;
+ EntryMode parentMode = (EntryMode.EPHEMERAL.equals(mode) ?
+ EntryMode.PERSISTENT : mode);
Review Comment:
I think we can we add some comment about this assumption ..
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -115,6 +117,41 @@ public void create(String key, Object data, MetaClientInterface.EntryMode mode)
}
}
+ @Override
+ public void recursiveCreate(String key, T data, EntryMode mode) {
+ recursiveCreateHelper(key, data, mode, -1);
+ }
+
+ @Override
+ public void recursiveCreateWithTTL(String key, T data, long ttl) {
+ recursiveCreateHelper(key, data, EntryMode.TTL, ttl);
+ }
+
+ private void recursiveCreateHelper(String key, T data, EntryMode mode, long ttl) {
+ boolean retry;
+ EntryMode parentMode = (EntryMode.EPHEMERAL.equals(mode) ?
+ EntryMode.PERSISTENT : mode);
+ do {
+ retry = false;
+ try {
+ if (EntryMode.TTL.equals(mode)) {
+ createWithTTL(key, data, ttl);
+ } else {
+ create(key, data, mode);
+ }
+ } catch (MetaClientNoNodeException e) {
+ retry = true;
+ String parentPath = getZkParentPath(key);
+ try {
+ recursiveCreateHelper(parentPath, null, parentMode, ttl);
+ } catch (MetaClientNodeExistsException e1) {
+ return;
Review Comment:
Should we not let this fail silently and return MetaClientException, so that client is aware of failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org