You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/01/22 00:55:53 UTC
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov opened a new pull
request #81: not building shared library anymore
AlexanderSaydakov opened a new pull request #81: not building shared library anymore
URL: https://github.com/apache/incubator-datasketches-cpp/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on issue #81: not
building shared library anymore
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #81: not building shared library anymore
URL: https://github.com/apache/incubator-datasketches-cpp/pull/81#issuecomment-577381900
Since we only build for unit testing, is the (more fragile) cmake alternative even needed? Should we just remove the Makefile option entirely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin merged pull request #81: not
building shared library anymore
Posted by GitBox <gi...@apache.org>.
jmalkin merged pull request #81: not building shared library anymore
URL: https://github.com/apache/incubator-datasketches-cpp/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov commented on issue
#81: not building shared library anymore
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #81: not building shared library anymore
URL: https://github.com/apache/incubator-datasketches-cpp/pull/81#issuecomment-578898729
I agree. Let us reduce unnecessary complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov commented on issue
#81: not building shared library anymore
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #81: not building shared library anymore
URL: https://github.com/apache/incubator-datasketches-cpp/pull/81#issuecomment-576958668
We completed our planned move to header-only library. Therefore the only code to compile is unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org