You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Suresh Balineni <sb...@juniper.net> on 2014/03/11 20:42:17 UTC

Review Request 19062: Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19062/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

Fix for ACL ingress rule mapping to Contrail Network policy implementation.

Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied


Diffs
-----

  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java 3092cad 

Diff: https://reviews.apache.org/r/19062/diff/


Testing
-------

verified locally.


Thanks,

Suresh Balineni


Re: Review Request 19062: Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied

Posted by Sheng Yang <sh...@yasker.org>.

> On March 18, 2014, 6 p.m., Sheng Yang wrote:
> > Ship It!

Committed to MASTER.

Thanks!


- Sheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19062/#review37577
-----------------------------------------------------------


On March 11, 2014, 7:42 p.m., Suresh Balineni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19062/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 7:42 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for ACL ingress rule mapping to Contrail Network policy implementation.
> 
> Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java 3092cad 
> 
> Diff: https://reviews.apache.org/r/19062/diff/
> 
> 
> Testing
> -------
> 
> verified locally.
> 
> 
> Thanks,
> 
> Suresh Balineni
> 
>


Re: Review Request 19062: Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied

Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19062/#review37577
-----------------------------------------------------------

Ship it!


Ship It!

- Sheng Yang


On March 11, 2014, 7:42 p.m., Suresh Balineni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19062/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 7:42 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for ACL ingress rule mapping to Contrail Network policy implementation.
> 
> Per contrail implementation, CS ingress policy mapping: rule cidr should be mapped to src net, dst net is 'local' i.e same as 'guest network' on which rule is applied
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java 3092cad 
> 
> Diff: https://reviews.apache.org/r/19062/diff/
> 
> 
> Testing
> -------
> 
> verified locally.
> 
> 
> Thanks,
> 
> Suresh Balineni
> 
>