You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/05 23:33:51 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2797: [GOBBLIN-948] add hive data node and descriptor

sv2000 commented on a change in pull request #2797: [GOBBLIN-948] add hive data node and descriptor
URL: https://github.com/apache/incubator-gobblin/pull/2797#discussion_r342851353
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/SqlDatasetDescriptor.java
 ##########
 @@ -52,6 +52,7 @@
   private final Config rawConfig;
 
   public enum  Platform {
+    HIVE("hive"),
 
 Review comment:
   Can we move the "hive" platform to the HiveDatasetDescriptor? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services