You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/18 10:29:14 UTC
[GitHub] [flink] JingsongLi opened a new pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
JingsongLi opened a new pull request #14116:
URL: https://github.com/apache/flink/pull/14116
## What is the purpose of the change
When set partition-commit.delay=0, Users expect partitions to be committed immediately.
However, if the record of this partition continues to flow in, the bucket for the partition will be activated, and no inactive bucket will appear.
## Brief change log
Consider listening to bucket created.
Collect partitions from bucket created listener. Emit partitions when notify checkpoint complete.
## Verifying this change
`StreamingFileWriterTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
}, {
"hash" : "088811826ab3a6a5a403260556c4f476b4802e2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10096",
"triggerID" : "088811826ab3a6a5a403260556c4f476b4802e2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766)
* 088811826ab3a6a5a403260556c4f476b4802e2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10096)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729588255
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4d59e87c09c2b2718d059804f26c6a5a60374326 (Wed Nov 18 10:31:59 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
}, {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "733501300",
"triggerType" : "MANUAL"
}, {
"hash" : "088811826ab3a6a5a403260556c4f476b4802e2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "088811826ab3a6a5a403260556c4f476b4802e2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10073) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766)
* 088811826ab3a6a5a403260556c4f476b4802e2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-733501300
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #14116:
URL: https://github.com/apache/flink/pull/14116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #14116:
URL: https://github.com/apache/flink/pull/14116#discussion_r530235283
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingFileWriter.java
##########
@@ -134,13 +143,19 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitUpToCheckpoint(long checkpointId) throws Exception {
helper.commitUpToCheckpoint(checkpointId);
+
+ NavigableMap<Long, Set<String>> newPartitions = this.newPartitions.headMap(checkpointId, true);
+ Set<String> partitions = new HashSet<>(committablePartitions);
+ committablePartitions.clear();
+ newPartitions.values().forEach(partitions::addAll);
+ newPartitions.clear();
Review comment:
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #14116:
URL: https://github.com/apache/flink/pull/14116#discussion_r530189998
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingFileWriter.java
##########
@@ -134,13 +143,19 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitUpToCheckpoint(long checkpointId) throws Exception {
helper.commitUpToCheckpoint(checkpointId);
+
+ NavigableMap<Long, Set<String>> newPartitions = this.newPartitions.headMap(checkpointId, true);
+ Set<String> partitions = new HashSet<>(committablePartitions);
+ committablePartitions.clear();
+ newPartitions.values().forEach(partitions::addAll);
+ newPartitions.clear();
Review comment:
Will clear the headMap also cleans the part before the current checkpoint in `this.newPartitions` ?
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingFileWriter.java
##########
@@ -134,13 +143,19 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitUpToCheckpoint(long checkpointId) throws Exception {
helper.commitUpToCheckpoint(checkpointId);
+
+ NavigableMap<Long, Set<String>> newPartitions = this.newPartitions.headMap(checkpointId, true);
Review comment:
Change to another name to avoid override variable names ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14116: [FLINK-20213][fs-connector] Partition commit is delayed when records keep coming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14116:
URL: https://github.com/apache/flink/pull/14116#issuecomment-729612452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766",
"triggerID" : "4d59e87c09c2b2718d059804f26c6a5a60374326",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d59e87c09c2b2718d059804f26c6a5a60374326 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9766)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org