You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2014/06/12 11:30:03 UTC
[jira] [Updated] (SOLR-6048) Fix asserts for SolrDocument,
SolrInputDocument and SolrInputField in SolrTestCaseJ4
[ https://issues.apache.org/jira/browse/SOLR-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Varun Thacker updated SOLR-6048:
--------------------------------
Attachment: SOLR-6048.patch
Patch which only corrects the testBackCompat() test and doesn't rename the methods.
> Fix asserts for SolrDocument, SolrInputDocument and SolrInputField in SolrTestCaseJ4
> ------------------------------------------------------------------------------------
>
> Key: SOLR-6048
> URL: https://issues.apache.org/jira/browse/SOLR-6048
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-6048.patch, SOLR-6048.patch
>
>
> SOLR-5265 added these asserts to check equality of SolrDocument, SolrInputDocument and SolrInputField instead of adding a compare method to any of these classes.
> But these are actually compare methods. So we should rename them to compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently in TestJavaBinCodec the backcompat test is broken.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org