[jira] [Commented] (LUCENE-5516) Forward information that trigger a merge to MergeScheduler

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930201#comment-13930201 ] 

Michael McCandless commented on LUCENE-5516:
--------------------------------------------

+1

Maybe just fix the naming so it's either foundNewMerges or newMergesFound?  I think I see both in IndexWriter.java.

> Forward information that trigger a merge to MergeScheduler
> ----------------------------------------------------------
>
>                 Key: LUCENE-5516
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5516
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.7
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.8, 5.0
>
>         Attachments: LUCENE-5516.patch
>
>
> Today we pass information about the merge trigger to the merge policy. Yet, no matter if the MP finds a merge or not we call the MergeScheduler who runs & blocks even if we didn't find a merge. In some cases we don't even want this to happen but inside the MergeScheduler we have no choice to opt out since we don't know what triggered the merge. We should forward the infos we have to the MergeScheduler as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org