You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/06 03:47:27 UTC

[GitHub] [submarine] noidname01 opened a new pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

noidname01 opened a new pull request #698:
URL: https://github.com/apache/submarine/pull/698


   ### What is this PR for?
   
   This is the frontend implementation of [SUBMARINE-943](https://issues.apache.org/jira/browse/SUBMARINE-943)
   Users can add multiple tags to mark experiments with their own category.
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   None
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-958
   
   ### How should this be tested?
   
   Just fill in the tags when creating an experiment.
   
   ### Screenshots (if appropriate)
   
   ![2021-08-06 11-46-03 的螢幕擷圖](https://user-images.githubusercontent.com/55401762/128453067-e282aed0-c93e-490b-85c3-d610fcdca667.png)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] noidname01 commented on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-894617073


   Done~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] noidname01 commented on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-899368410


   @pingsutw I also add e2e test for tags.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #698:
URL: https://github.com/apache/submarine/pull/698


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] noidname01 edited a comment on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
noidname01 edited a comment on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-899368410


   @pingsutw I also add tags in experimentIT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-895181063


   Hi @noidname01, Could you fix the conflict? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-898194930


   @noidname01 sorry, there is another conflict in the PR, could you fix it?
   I will merge it first. Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] noidname01 commented on a change in pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
noidname01 commented on a change in pull request #698:
URL: https://github.com/apache/submarine/pull/698#discussion_r683948111



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
##########
@@ -133,6 +136,10 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
     });
 
     this.subscriptions.push(sub1, sub2);
+
+    // get tags from server
+    this.listOfOption = []; //TODO

Review comment:
       Oh you're right, I'll fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on a change in pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #698:
URL: https://github.com/apache/submarine/pull/698#discussion_r683947326



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
##########
@@ -133,6 +136,10 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
     });
 
     this.subscriptions.push(sub1, sub2);
+
+    // get tags from server
+    this.listOfOption = []; //TODO

Review comment:
       ```suggestion
       // TODO: get tags from server
       this.listOfOption = [];
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] noidname01 commented on pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #698:
URL: https://github.com/apache/submarine/pull/698#issuecomment-895202109


   > Hi @noidname01, Could you fix the conflict? Thanks.
   
   @pingsutw Fixed~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on a change in pull request #698: SUBMARINE-958. Experiment Tag at Customized Experiment

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #698:
URL: https://github.com/apache/submarine/pull/698#discussion_r683973985



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
##########
@@ -133,6 +136,10 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
     });
 
     this.subscriptions.push(sub1, sub2);
+
+    // get tags from server
+    this.listOfOption = []; //TODO

Review comment:
       Thanks~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org