You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/02/23 22:38:36 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4307: HDDS-8020. File checksum helper leaking client

adoroszlai opened a new pull request, #4307:
URL: https://github.com/apache/ozone/pull/4307

   ## What changes were proposed in this pull request?
   
   Let file checksum helper release client in case of success to prevent memleak.
   
   (It seems logic for releasing client was copied from `BlockInputStream`, which has been fixed in HDDS-7931 since then.)
   
   https://issues.apache.org/jira/browse/HDDS-8020
   
   ## How was this patch tested?
   
   ```
   mvn clean test -am -pl :ozone-integration-test -Dtest='TestOzoneFileChecksum'
   ```
   
   Verified no warning about `ManagedChannelImpl was not shutdown properly` appears in test log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4307: HDDS-8020. File checksum helper leaking client

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4307:
URL: https://github.com/apache/ozone/pull/4307#issuecomment-1444147337

   Thanks @ayushtkn, @duongkame, @sodonnel for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4307: HDDS-8020. File checksum helper leaking client

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4307:
URL: https://github.com/apache/ozone/pull/4307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org