[GitHub] [ozone] smengcl commented on a diff in pull request #5045: HDDS-8994. [Multi-Tenant] Add CLI option to allow tenant creation on top of existing volumes

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #5045:
URL: https://github.com/apache/ozone/pull/5045#discussion_r1262838195


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -885,14 +885,21 @@ public void createTenant(String tenantId, TenantArgs tenantArgs)
     final String volumeName = tenantArgs.getVolumeName();
     verifyVolumeName(volumeName);
 
+    final boolean forceCreationWhenVolumeExists =
+        tenantArgs.getForceCreationWhenVolumeExists();
+
     OmTenantArgs.Builder builder = OmTenantArgs.newBuilder();
     builder.setTenantId(tenantId);
     builder.setVolumeName(volumeName);
-    // TODO: Add more fields
-    // TODO: Include OmVolumeArgs in (Om)TenantArgs as well for volume creation?
+    builder.setForceCreationWhenVolumeExists(
+        tenantArgs.getForceCreationWhenVolumeExists());
+
+    // TODO: Add more fields. e.g. include OmVolumeArgs in (Om)TenantArgs

Review Comment:
   Yes that is still a TODO item for volume creation customization during tenant creation. Unrelated to this item.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org