[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22989: fix: Form data was not being passed to save/update slice

["lyndsiWilliams (via GitHub)" <gi...@apache.org>]

lyndsiWilliams commented on code in PR #22989:
URL: https://github.com/apache/superset/pull/22989#discussion_r1096120244


##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -198,6 +198,8 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
         );
       }
 
+      const { url_params, ...formData } = this.props.form_data || {};

Review Comment:
   <img width="638" alt="Screenshot 2023-02-03 at 12 23 13 PM" src="https://user-images.githubusercontent.com/55605634/216678564-93cb29aa-3437-44ff-9707-4dcc558a60a0.png">
   
   This introduces a warning because `url_params` is never used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org