[GitHub] [ozone] symious commented on a diff in pull request #4075: HDDS-7630. Show detailed OMResponse when OzoneManagerDoubleBuffer terminates

[GitBox <gi...@apache.org>]

symious commented on code in PR #4075:
URL: https://github.com/apache/ozone/pull/4075#discussion_r1062058392


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -386,11 +389,14 @@ private void flushTransactions() {
               + "exit.", Thread.currentThread().getName());
         }
       } catch (IOException ex) {
-        terminate(ex);
+        terminate(ex, omResponse.get());
       } catch (Throwable t) {
-        final String s = "OMDoubleBuffer flush thread " +
-            Thread.currentThread().getName() + " encountered Throwable error";
-        ExitUtils.terminate(2, s, t, LOG);
+        StringBuilder s = new StringBuilder("OMDoubleBuffer flush thread " +

Review Comment:
   @duongkame Thank you for the suggestions, updated the patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org