[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #831: MINIFICPP-1280 - StringUtils::replaceAll hangs in case from_string is…

[GitBox <gi...@apache.org>]

fgerlits commented on a change in pull request #831:
URL: https://github.com/apache/nifi-minifi-cpp/pull/831#discussion_r450239801



##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -572,6 +572,9 @@ bool ConsumeWindowsEventLog::createEventRender(EVT_HANDLE hEvent, EventRender& e
 
       for (const auto &mapEntry : walker.getIdentifiers()) {
         // replace the identifiers with their translated strings.
+        if (mapEntry.first.empty() || mapEntry.second.empty()) {
+          continue;  // This is most probably a result of a failed ID resolution
+        }

Review comment:
       I would move this check to the top of `StringUtils::replaceAll()`, as a `"" -> ""` replacement should always be a no-op, and there is no reason to potentially iterate over a long string character-by-character in these cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org