[GitHub] [cassandra] yifan-c commented on a diff in pull request #1703: CASSANDRA-17700 Remove usage of deprecated IP based authenticate method call

[GitBox <gi...@apache.org>]

yifan-c commented on code in PR #1703:
URL: https://github.com/apache/cassandra/pull/1703#discussion_r908850686


##########
src/java/org/apache/cassandra/auth/IInternodeAuthenticator.java:
##########
@@ -82,11 +82,18 @@ default void setupInternode()
     }
 
     /**
-     * Enum that represents connection type of an internode connection.
+     * Enum that represents connection type of internode connection.
+     *
+     * INBOUND - called after connection established, with certificate available if present.
+     * OUTBOUND - called after connection established, with certificate available if present.
+     * PRECONNECT - called before initiating a connection, without certificate available.

Review Comment:
   nit: update the name.



##########
test/distributed/org/apache/cassandra/distributed/test/InternodeEncryptionEnforcementTest.java:
##########
@@ -352,6 +352,10 @@ public static class CertificateVerifyAuthenticator implements IInternodeAuthenti
         @Override
         public boolean authenticate(InetAddress remoteAddress, int remotePort, Certificate[] certificates, InternodeConnectionDirection connectionType)
         {
+            if (connectionType.equals(InternodeConnectionDirection.OUTBOUND_PRECONNECT))

Review Comment:
   nit: enum equality check can just use `==`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org