You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/10/30 09:24:18 UTC
[PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Xuanwo opened a new pull request, #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423#discussion_r1375910974
##########
core/src/docs/upgrade.md:
##########
@@ -15,6 +15,10 @@ OpenDAL bumps it's MSRV to 1.67.0.
- The `write_min_size` option has been deprecated and replaced by `BufferedWriter`, also introduced in version 0.40.
- A new setting, `allow_anonymous`, has been added. Since v0.41, OSS will now return an error if credential loading fails. Enabling `allow_anonymous` to fallback to request without credentials.
+### Ghac Service Configuration
+
+- The `enable_create_simulation` option has been removed. We add this option to allow ghac simulate create file, but it's could result in unexpected behavior when users create a file with content length `1`. So we remove it.
Review Comment:
```suggestion
- The `enable_create_simulation` option has been removed. We add this option to allow ghac simulate create empty file, but it's could result in unexpected behavior when users create a file with content length `1`. So we remove it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423#issuecomment-1784834832
cc @suyanhanx, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Posted by "huonw (via GitHub)" <gi...@apache.org>.
huonw commented on PR #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423#issuecomment-1784897063
No, Pants doesn't use this. It handles the empty file in a different way. Thanks for checking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/ghac)!: Remove enable_create_simulation support for ghac [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3423:
URL: https://github.com/apache/incubator-opendal/pull/3423#issuecomment-1784797230
Just to be sure, @huonw, are you relying on this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org