[GitHub] [hudi] vinothchandar commented on a diff in pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12

["vinothchandar (via GitHub)" <gi...@apache.org>]

vinothchandar commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102343190


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
  * </ol>
  */
 class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with KryoRegistrator {
+
   override def registerClasses(kryo: Kryo): Unit = {
     ///////////////////////////////////////////////////////////////////////////
     // NOTE: DO NOT REORDER REGISTRATIONS
     ///////////////////////////////////////////////////////////////////////////
     super[HoodieCommonKryoRegistrar].registerClasses(kryo)
 
+    kryo.register(classOf[HoodieKey], new HoodieKeySerializer)

Review Comment:
   I guess this ONLY applied to the shuffle and not for the actual serialization? i,e this instance of kryo is not a shared/singleton or sth. correcT? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org