You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/12/22 15:08:17 UTC
[GitHub] zeppelin pull request #1793: [MINOR] Refactoring Job and Paragraph
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1793
[MINOR] Refactoring Job and Paragraph
### What is this PR for?
Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594(#1753), thus all reviewers click the last commit and review it.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Moved these variables into Paragraph
### What is the Jira issue?
N/A
### How should this be tested?
All things are same as before
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin minor/refactoring-job-paragraph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1793.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1793
----
commit f62727839154532287f44567807319c180b8942c
Author: Jongyoul Lee <jl...@jongyouls-macbook-pro.local>
Date: 2016-12-13T15:52:15Z
Supported personalized mode
commit a7c91f1ba037a1642eab2cf1f5719d0cb56f58a0
Author: Jongyoul Lee <jl...@jongyouls-macbook-pro.local>
Date: 2016-12-13T16:12:50Z
Fixed the bug while not using personalized mode
commit 4fabd8872f1c40265e4a4036b0ed60c15717c870
Author: Jongyoul Lee <jl...@jongyouls-macbook-pro.local>
Date: 2016-12-14T14:29:29Z
Fixed style
commit 20425e7ef3205748e8d0606eeade84f3f00848fd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-12-14T16:07:31Z
add toggleNotePersonalizedMode and ui
commit 9fcb7f8ef487382b4ab847e55fde39f4c2f34c7a
Author: CloverHearts <cl...@gmail.com>
Date: 2016-12-14T19:18:36Z
implement ui
commit f59d26a34ac23b2ff9cf3d03cd8198b6176d9e94
Author: CloverHearts <cl...@gmail.com>
Date: 2016-12-14T19:19:40Z
implement update personalized mode websocket event in backend
commit 2c7bd398c381ebbc84d1b1b2ff2b08912ffae36e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-12-15T05:45:52Z
broadcast bugfix
commit 70f68d88dc7b71e5bca194a8eb476ecf2eb0c10e
Author: Jongyoul Lee <jl...@jongyouls-macbook-pro.local>
Date: 2016-12-20T07:10:19Z
Fixed dynamic forms
Fixed NPE while broadcasting userParagraphsMap
commit a9d8f7ee04c65b7c444cb71a7429b80239932104
Author: CloverHearts <cl...@users.noreply.github.com>
Date: 2016-12-20T07:26:26Z
change mode name shared to collaboration and dialog message (#5)
* change mode name shared to collaboration and dialog message
* change dialog message Collaboration -> collaborate,
commit 893fbbc176641b9cd36bcd26bd66330c234fee78
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-12-22T14:53:04Z
Moved result(s) from Job into Paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1793: [MINOR] Refactoring Job and Paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1793
Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1793: [WIP][MINOR] Refactoring Job and Paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1793
I've rebased after merging #1753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1793: [MINOR] Refactoring Job and Paragraph
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1793
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1793: [WIP][MINOR] Refactoring Job and Paragraph
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1793
```
Failed tests:
NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 expected:<ABORT> but was:<RUNNING>
```
This test passed in my local
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---