You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by davsclaus <gi...@git.apache.org> on 2015/03/26 22:34:27 UTC
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
GitHub user davsclaus opened a pull request:
https://github.com/apache/activemq-6/pull/196
Polish and renamed hornetmq to activemq-6
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davsclaus/activemq-6 polish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit 31cdedca5736d7be5fd7e2e843d76cd9e6fda436
Author: Claus Ibsen <cl...@gmail.com>
Date: 2015-03-26T21:36:27Z
Polish and renamed hornetmq to activemq-6
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-6/pull/196#issuecomment-86735537
The references to "HornetMQ" probably weren't caught earlier because nobody thought to search for "HornetMQ" since the broker's name is "HornetQ" (without the "M").
I think that any JIRA links which reference the HORNETQ project should stay as is so historical information remains in-tact.
I also think the references in checkstyle.xml are also legit since they reference code used for checkstyle checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/196#issuecomment-86749202
I contributed that check style I wrote to check style. They refactored it and I'm waiting to be released on their satellite project before I can remove this and replace it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
Posted by davsclaus <gi...@git.apache.org>.
Github user davsclaus commented on the pull request:
https://github.com/apache/activemq-6/pull/196#issuecomment-86727631
There were 2 left over comments about hornetmq in the activemq6 source code. Now a git grep returns empty
```
davsclaus:~/workspace/activemq-6 (polish)/$ git grep -i "hornetmq"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
Posted by HornetQBot <gi...@git.apache.org>.
Github user HornetQBot commented on the pull request:
https://github.com/apache/activemq-6/pull/196#issuecomment-86727658
Can one of the admins verify this patch by saying "ok to test"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Polish and renamed hornetmq to activemq-6
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-6/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---