You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "wg1026688210 (via GitHub)" <gi...@apache.org> on 2023/06/30 07:55:46 UTC

[GitHub] [incubator-paimon] wg1026688210 opened a new pull request, #1469: [Flink]update union list state

wg1026688210 opened a new pull request, #1469:
URL: https://github.com/apache/incubator-paimon/pull/1469

   ### Purpose
   fix the list state which lead that jm heap oom
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1469: [Flink]update union list state

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1469:
URL: https://github.com/apache/incubator-paimon/pull/1469#discussion_r1247558623


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/StateUtils.java:
##########
@@ -58,10 +60,15 @@ public class StateUtils {
                     "Expecting 0 value for a fresh state but found "
                             + values.size()
                             + ". This is unexpected.");
-            state.add(defaultValue);
+        }
+
+        if (values.isEmpty()){
             values.add(defaultValue);
         }
 
-        return values.get(0);
+        T value = values.get(0);
+        state.update(Lists.newArrayList(value));

Review Comment:
   we need to an ut case to cover this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi merged pull request #1469: [Flink]update union list state to avoid inflation

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1469:
URL: https://github.com/apache/incubator-paimon/pull/1469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org