You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2010/05/04 04:44:56 UTC
[jira] Created: (SLING-1516) FSResource Provider throws exception
on first activate.
FSResource Provider throws exception on first activate.
-------------------------------------------------------
Key: SLING-1516
URL: https://issues.apache.org/jira/browse/SLING-1516
Project: Sling
Issue Type: Bug
Affects Versions: File System Resource Provider 0.9.2
Reporter: Ian Boston
Assignee: Ian Boston
Fix For: File System Resource Provider 1.0.2
04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reopened SLING-1516:
--------------------------------------
Thanks for taking this !
I think the solution is different, though, probably: The idea of the component is that it is created by factory configurations and no component instance should be present if there is no factory configuration instance.
Thus the solution is to set the configuration policy to "require" (112.4.3) by adding
policy="require"
to he @scr.component tag.
> FSResource Provider throws exception on first activate.
> -------------------------------------------------------
>
> Key: SLING-1516
> URL: https://issues.apache.org/jira/browse/SLING-1516
> Project: Sling
> Issue Type: Bug
> Affects Versions: File System Resource Provider 0.9.2
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: File System Resource Provider 1.0.2
>
>
> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
> Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-1516.
-------------------------------
Resolution: Fixed
Fixed.
> FSResource Provider throws exception on first activate.
> -------------------------------------------------------
>
> Key: SLING-1516
> URL: https://issues.apache.org/jira/browse/SLING-1516
> Project: Sling
> Issue Type: Bug
> Affects Versions: File System Resource Provider 0.9.2
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: File System Resource Provider 1.0.2
>
>
> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
> Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863637#action_12863637 ]
Ian Boston commented on SLING-1516:
-----------------------------------
FSResource is configured as a ConfigurationFactory however it make not distinction between an activate for an alias PID and the real PID.
It should look at the properties to determine why its being activated. see OSGi 4.2 Compendium v 1.1 section 115.3.1
I think a simple check for the existence of the service.factoryPid property should identify when the activation is as a result of a configuration.
> FSResource Provider throws exception on first activate.
> -------------------------------------------------------
>
> Key: SLING-1516
> URL: https://issues.apache.org/jira/browse/SLING-1516
> Project: Sling
> Issue Type: Bug
> Affects Versions: File System Resource Provider 0.9.2
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: File System Resource Provider 1.0.2
>
>
> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
> Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by Felix Meschberger <fm...@gmail.com>.
Thanks.
Regards
Felix
On 04.05.2010 07:50, Ian Boston (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Ian Boston resolved SLING-1516.
> -------------------------------
>
> Resolution: Fixed
>
> Yes, thats a much better way of doing it. I couldnt make much sense of the spec in this area, so thank you.
>
> Reverted my attempt and used your suggestion. Fixes the problem.
>
>> FSResource Provider throws exception on first activate.
>> -------------------------------------------------------
>>
>> Key: SLING-1516
>> URL: https://issues.apache.org/jira/browse/SLING-1516
>> Project: Sling
>> Issue Type: Bug
>> Affects Versions: File System Resource Provider 0.9.2
>> Reporter: Ian Boston
>> Assignee: Ian Boston
>> Fix For: File System Resource Provider 1.0.2
>>
>>
>> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
>> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>> at java.lang.reflect.Method.invoke(Method.java:597)
>> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
>> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
>> Seeing these when FSResource is present and not configured.
>
[jira] Resolved: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-1516.
-------------------------------
Resolution: Fixed
Yes, thats a much better way of doing it. I couldnt make much sense of the spec in this area, so thank you.
Reverted my attempt and used your suggestion. Fixes the problem.
> FSResource Provider throws exception on first activate.
> -------------------------------------------------------
>
> Key: SLING-1516
> URL: https://issues.apache.org/jira/browse/SLING-1516
> Project: Sling
> Issue Type: Bug
> Affects Versions: File System Resource Provider 0.9.2
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: File System Resource Provider 1.0.2
>
>
> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
> Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by Carsten Ziegeler <cz...@apache.org>.
> Urgs, impossible :)
>
> Seriously, this change should really be transparent as by default no
> path is configured; but I'll have a look.
>
Hmpf, actually it was a collateral damage; I accidentally changed the
script resolution just a little bit......that's now fixed with revision
940750.
Sorry
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 04.05.10 07:22, schrieb Ian Boston:
>
> I think it was caused by this commit, will validate in a minute.
>
> x43543-2:trunk ieb$ git bisect good
> bfb78d6d6540bf1c7ac8d2223dd6cf36219a6814 is first bad commit
> commit bfb78d6d6540bf1c7ac8d2223dd6cf36219a6814
> Author: cziegeler <cz...@13f79535-47bb-0310-9956-ffa450edef68>
> Date: Thu Apr 29 16:19:57 2010 +0000
>
> SLING-1512 : Make script execution paths configurable
>
> git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@939362 13f79535-47bb-0310-9956-ffa450edef68
>
> :040000 040000 e3e14418da29a54bfd9276515f06323a11247760 91a99331029baa05b741a1db12a6bf0db1750387 M bundles
> x43543-2:trunk ieb$
>
Urgs, impossible :)
Seriously, this change should really be transparent as by default no
path is configured; but I'll have a look.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception on first activate.
Posted by Ian Boston <ie...@tfd.co.uk>.
On 4 May 2010, at 14:36, Ian Boston wrote:
>
> On 4 May 2010, at 14:03, Justin Edelson wrote:
>>>
>> I was actually kidding. I'm not sure when the test failures started. But if you want to fix them, go for it.
>>
>> Justin
>
>
> It broke here http://hudson.zones.apache.org/hudson/job/sling-trunk-1.5/698/
>
> Just running a bisect to see if I can narrow it down some more, but there were quite a few intertwined commits in that build.
> Ian
I think it was caused by this commit, will validate in a minute.
x43543-2:trunk ieb$ git bisect good
bfb78d6d6540bf1c7ac8d2223dd6cf36219a6814 is first bad commit
commit bfb78d6d6540bf1c7ac8d2223dd6cf36219a6814
Author: cziegeler <cz...@13f79535-47bb-0310-9956-ffa450edef68>
Date: Thu Apr 29 16:19:57 2010 +0000
SLING-1512 : Make script execution paths configurable
git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@939362 13f79535-47bb-0310-9956-ffa450edef68
:040000 040000 e3e14418da29a54bfd9276515f06323a11247760 91a99331029baa05b741a1db12a6bf0db1750387 M bundles
x43543-2:trunk ieb$
>
>
>>
>>>>
>>>
>
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception on first activate.
Posted by Ian Boston <ie...@tfd.co.uk>.
On 4 May 2010, at 14:03, Justin Edelson wrote:
>>
> I was actually kidding. I'm not sure when the test failures started. But if you want to fix them, go for it.
>
> Justin
It broke here http://hudson.zones.apache.org/hudson/job/sling-trunk-1.5/698/
Just running a bisect to see if I can narrow it down some more, but there were quite a few intertwined commits in that build.
Ian
>
>>>
>>
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception on first activate.
Posted by Justin Edelson <ju...@gmail.com>.
On May 3, 2010, at 11:59 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>
> On 4 May 2010, at 12:56, Justin Edelson wrote:
>
>> On 5/3/10 10:54 PM, Ian Boston wrote:
>>>
>>> On 4 May 2010, at 12:46, Justin Edelson (JIRA) wrote:
>>>
>>>>
>>>> [ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863636#action_12863636 ]
>>>>
>>>> Justin Edelson commented on SLING-1516:
>>>> ---------------------------------------
>>>>
>>>> thanks for taking this Ian.
>>>
>>> No problem,
>>> It was winding me up seeing the exception :)
>>> again and again.
>>>
>>> Ian
>>>
>> Cool. You don't feel like fixing the broken integration tests do you? :)
>
> Opps, that was probably me, sure, will do.
> Sorry.
> Ian
>
I was actually kidding. I'm not sure when the test failures started. But if you want to fix them, go for it.
Justin
>>
>
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception on first activate.
Posted by Ian Boston <ie...@tfd.co.uk>.
On 4 May 2010, at 12:56, Justin Edelson wrote:
> On 5/3/10 10:54 PM, Ian Boston wrote:
>>
>> On 4 May 2010, at 12:46, Justin Edelson (JIRA) wrote:
>>
>>>
>>> [ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863636#action_12863636 ]
>>>
>>> Justin Edelson commented on SLING-1516:
>>> ---------------------------------------
>>>
>>> thanks for taking this Ian.
>>
>> No problem,
>> It was winding me up seeing the exception :)
>> again and again.
>>
>> Ian
>>
> Cool. You don't feel like fixing the broken integration tests do you? :)
Opps, that was probably me, sure, will do.
Sorry.
Ian
>
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by Justin Edelson <ju...@gmail.com>.
On 5/3/10 10:54 PM, Ian Boston wrote:
>
> On 4 May 2010, at 12:46, Justin Edelson (JIRA) wrote:
>
>>
>> [ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863636#action_12863636 ]
>>
>> Justin Edelson commented on SLING-1516:
>> ---------------------------------------
>>
>> thanks for taking this Ian.
>
> No problem,
> It was winding me up seeing the exception :)
> again and again.
>
> Ian
>
Cool. You don't feel like fixing the broken integration tests do you? :)
Re: [jira] Commented: (SLING-1516) FSResource Provider throws exception on first activate.
Posted by Ian Boston <ie...@tfd.co.uk>.
On 4 May 2010, at 12:46, Justin Edelson (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863636#action_12863636 ]
>
> Justin Edelson commented on SLING-1516:
> ---------------------------------------
>
> thanks for taking this Ian.
No problem,
It was winding me up seeing the exception :)
again and again.
Ian
[jira] Commented: (SLING-1516) FSResource Provider throws exception
on first activate.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863636#action_12863636 ]
Justin Edelson commented on SLING-1516:
---------------------------------------
thanks for taking this Ian.
> FSResource Provider throws exception on first activate.
> -------------------------------------------------------
>
> Key: SLING-1516
> URL: https://issues.apache.org/jira/browse/SLING-1516
> Project: Sling
> Issue Type: Bug
> Affects Versions: File System Resource Provider 0.9.2
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: File System Resource Provider 1.0.2
>
>
> 04.05.2010 11:07:03.367 *ERROR* [SCR Component Actor] org.apache.sling.fsresource [org.apache.sling.fsprovider.internal.FsResourceProvider] The activate method has thrown an exception (java.lang.IllegalArgumentException: provider.roots property must be set) java.lang.IllegalArgumentException: provider.roots property must be set
> at org.apache.sling.fsprovider.internal.FsResourceProvider.activate(FsResourceProvider.java:206)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:213)
> at org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:38)
> Seeing these when FSResource is present and not configured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.