You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by eminency <gi...@git.apache.org> on 2015/10/07 10:42:44 UTC

[GitHub] tajo pull request: TAJO-1918: Text (de)serialization should be fix...

GitHub user eminency opened a pull request:

    https://github.com/apache/tajo/pull/814

    TAJO-1918: Text (de)serialization should be fixed for some types

    Fix getBytes to getTextBytes or use proper charset.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eminency/tajo TAJO-1918

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #814
    
----
commit a8b6e3361fb69abb70649d72bbc74708977a84bd
Author: Jongyoung Park <em...@gmail.com>
Date:   2015-10-07T08:40:55Z

    Fix getBytes to getTextBytes or use proper charset.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1918: Text (de)serialization should be fix...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/814#issuecomment-146123341
  
    Thanks for your contribution
    Could you add some tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1918: Text (de)serialization should be fix...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/814


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1918: Text (de)serialization should be fix...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/814#issuecomment-146442482
  
    +1
    I verified 'mvn clean install’ and the test failure is not related to this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---