[druid] branch master updated: fix task metric types in statsd emitter (#10764)

[xv...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

xvrl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new c5ecbf6  fix task metric types in statsd emitter (#10764)
c5ecbf6 is described below

commit c5ecbf67944b4d4e1a550553fa1cf8a1b2a7f928
Author: Xavier Léauté <xv...@apache.org>
AuthorDate: Fri Jan 15 11:39:51 2021 -0800

    fix task metric types in statsd emitter (#10764)
    
    except success and failure stats, task count metrics should all be
    gauges, since they represent the current state and not some aggregate
    counter over time.
---
 .../src/main/resources/defaultMetricDimensions.json      | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json b/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
index 287aaf6..1b17a4c 100644
--- a/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
+++ b/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
@@ -59,15 +59,15 @@
 
   "task/success/count" : { "dimensions" : ["dataSource"], "type" : "count" },
   "task/failed/count" : { "dimensions" : ["dataSource"], "type" : "count" },
-  "task/running/count" : { "dimensions" : ["dataSource"], "type" : "count" },
-  "task/pending/count" : { "dimensions" : ["dataSource"], "type" : "count" },
-  "task/waiting/count" : { "dimensions" : ["dataSource"], "type" : "count" },
+  "task/running/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+  "task/pending/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+  "task/waiting/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
 
-  "taskSlot/total/count" : { "dimensions" : [], "type" : "count" },
-  "taskSlot/idle/count" : { "dimensions" : [], "type" : "count" },
-  "taskSlot/busy/count" : { "dimensions" : [], "type" : "count" },
-  "taskSlot/lazy/count" : { "dimensions" : [], "type" : "count" },
-  "taskSlot/blacklisted/count" : { "dimensions" : [], "type" : "count" },
+  "taskSlot/total/count" : { "dimensions" : [], "type" : "gauge" },
+  "taskSlot/idle/count" : { "dimensions" : [], "type" : "gauge" },
+  "taskSlot/busy/count" : { "dimensions" : [], "type" : "gauge" },
+  "taskSlot/lazy/count" : { "dimensions" : [], "type" : "gauge" },
+  "taskSlot/blacklisted/count" : { "dimensions" : [], "type" : "gauge" },
 
   "task/run/time" : { "dimensions" : ["dataSource", "taskType"], "type" : "timer" },
   "segment/added/bytes" : { "dimensions" : ["dataSource", "taskType"], "type" : "count" },


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org