[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #763: code clean

[GitBox <gi...@apache.org>]

gaoxinge commented on a change in pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763#discussion_r491260820



##########
File path: config/remote_config.go
##########
@@ -40,7 +40,7 @@ type RemoteConfig struct {
 	TimeoutStr string            `default:"5s" yaml:"timeout" json:"timeout,omitempty"`
 	Username   string            `yaml:"username" json:"username,omitempty" property:"username"`
 	Password   string            `yaml:"password" json:"password,omitempty"  property:"password"`
-	Params     map[string]string `yaml:"params" json:"address,omitempty"`
+	Params     map[string]string `yaml:"params" json:"params,omitempty"`

Review comment:
       https://github.com/apache/dubbo-go/blob/811f4f1a2dcc75b4294f62cb795da0f3f399be93/config/remote_config.go#L37-L44
   
   This is another json tag `address` for `Address`. I think that tag `address` for `Params` is duplicated and wrong.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org