[GitHub] srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed on a kubernetes cluster

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #1950: Enable Pulsar Functions to be deployed on a kubernetes cluster
URL: https://github.com/apache/pulsar/pull/1950#discussion_r220679070
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
 ##########
 @@ -68,18 +72,12 @@ public void start() throws Exception {
         log.info("{}/{}/{}-{} RuntimeSpawner starting function", details.getTenant(), details.getNamespace(),
                 details.getName(), this.instanceConfig.getInstanceId());
 
-        if (instanceConfig.getFunctionDetails().getRuntime() == PYTHON
 
 Review comment:
   This is a leftover that I fixed within this change. Let me redo that in another pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services