You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bustios <gi...@git.apache.org> on 2016/08/02 21:25:36 UTC
[GitHub] zeppelin pull request #1267: [ZEPPELIN-1261] Bug fix in z.show() for matplot...
GitHub user bustios opened a pull request:
https://github.com/apache/zeppelin/pull/1267
[ZEPPELIN-1261] Bug fix in z.show() for matplotlib graphs
### What is this PR for?
Bug fix in z.show() for matplotlib graphs and code refactoring
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-1261](https://issues.apache.org/jira/browse/ZEPPELIN-1261)
### How should this be tested?
```
%python
import matplotlib.pyplot as plt
x = [1,2,3,4,5]
y = [6,7,8,9,0]
plt.plot(x, y, marker="o")
z.show(plt, height="20em")
plt.close()
```
```
%python
import matplotlib.pyplot as plt
x = [1,2,3,4,5]
y = [6,7,8,9,0]
plt.plot(x, y, marker="o")
z.show(plt, height="300px")
plt.close()
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bustios/zeppelin ZEPPELIN-1261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1267
----
commit 3e0ef22121d3858206f9af1787bf79108f9f2ed6
Author: Paul Bustios <pb...@gmail.com>
Date: 2016-08-02T20:55:56Z
Bug fix in show_matplotlib
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1267: [ZEPPELIN-1261] Bug fix in z.show() for matplotlib gra...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1267
Sounds great! Apparently CI failure has been addressed in #1259 as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1267: [ZEPPELIN-1261] Bug fix in z.show() for matplot...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1267: [ZEPPELIN-1261] Bug fix in z.show() for matplotlib gra...
Posted by bustios <gi...@git.apache.org>.
Github user bustios commented on the issue:
https://github.com/apache/zeppelin/pull/1267
I see. Thanks for your help and information @bzz. I'll keep it in mind for subsequent PRs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1267: [ZEPPELIN-1261] Bug fix in z.show() for matplotlib gra...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1267
Looks great to me, thank you @bustios !
Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---