You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "cpoerschke (via GitHub)" <gi...@apache.org> on 2024/09/09 12:27:19 UTC
[PR] remove deprecated SolrParams methods [solr]
cpoerschke opened a new pull request, #2700:
URL: https://github.com/apache/solr/pull/2700
Noticed whilst code reading. The methods appear to have been deprecated in Solr 7.4 -- https://issues.apache.org/jira/browse/SOLR-11914 -- and so the removal here can be both for `main` and `branch_9x` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] remove deprecated SolrParams methods [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2700:
URL: https://github.com/apache/solr/pull/2700#discussion_r1750228899
##########
solr/core/src/test/org/apache/solr/search/TestMinHashQParser.java:
##########
@@ -417,8 +417,7 @@ public void testBandsWrap() throws SyntaxError {
QParser qparser =
h.getCore()
.getQueryPlugin("minhash")
- .createParser(
- "1, 2, 3, 4, 5, 6, 7, 8, 9, 10", SolrParams.toSolrParams(par), null, null);
+ .createParser("1, 2, 3, 4, 5, 6, 7, 8, 9, 10", par.toSolrParams(), null, null);
Review Comment:
"par"? Sort of a nitpick, but maybe a more descriptive variable name? "params'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] remove deprecated SolrParams methods [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke merged PR #2700:
URL: https://github.com/apache/solr/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org