[GitHub] [superset] rusackas commented on a diff in pull request #19558: feat(explore): Redesign of Run/Save buttons

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19558:
URL: https://github.com/apache/superset/pull/19558#discussion_r846372171


##########
superset-frontend/src/components/Chart/Chart.jsx:
##########
@@ -288,6 +288,23 @@ class Chart extends React.PureComponent {
       );
     }
 
+    if (
+      !isLoading &&
+      !chartAlert &&
+      isFaded &&
+      ensureIsArray(queriesResponse).length === 0
+    ) {
+      return (
+        <EmptyStateBig
+          title={t('Your chart is ready to go!')}
+          description={t(
+            'Click on "Create chart" button in the control panel on the left to preview a visualisation',

Review Comment:
   In the US, yes. We're weird. We also optimize and scrutinize and so forth. Maybe one day we'll have American English and English localizations fleshed out :D



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org