You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 18:15:34 UTC

[GitHub] [airflow] umangs94 opened a new issue, #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

umangs94 opened a new issue, #25992:
URL: https://github.com/apache/airflow/issues/25992

   ### Description
   
   The Variable List in the Airflow UI used to show the variable values in a multiline format. This made it easy to see the values without having to click into the specific Variable. So it would be great if an option could be added to bring back the old multiline view (<=2.2.3).
   
   ### Use case/motivation
   
   We use multiple Airflow variables to maintain lists of table names (used in different DAGs), hence, I could easily do a Find on the page to see if a specific table was referenced inside any variable. After updating to 2.3.4, the Variable values in Airflow > Variable List only show a single-line of the Variable values, so the Find still works, however, now I can't see the variable that a specific table is referenced in as I can't see past the first few characters of the Variable values.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1233514517

   It could help actually. search in page could have found it. One thing is how you present to the user and what the page contains. It could even be a folded "full text" that you could reveal when clicked.
   
   No - no guidance. We are developing a product not a custom solution If you need to customise it, you ar efree to do so (but then we only focus on making features for everyone not focusing on single user). If you can help and hash out a solution that can make it into a product - that's cool. But if you want to customise it, taking time of people who work on a product is not the best idea (but feel free to do it on your own time).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1228784904

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1233402091

   We could add tooltip showing full variable. While it is not the same, I think it has the nice property of having more consistent UI in "table view" (It is disturbing to get table values with changing row height), it does not need extra click - enought to "focus" (with mouse) on the variable in question.  Bonus if we could make copy&paste work for full value as wel - even if we only show a truncated version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] spatocode commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
spatocode commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1233149672

   I believe this was removed for better UX. I don't think adding multi-line is good for UX if the value becomes too long. @potiuk What do you think?
   
   ![2022-08-31_17-10](https://user-images.githubusercontent.com/37238008/187727998-8a20d423-f36a-4885-babb-38edbf7b4e4a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] umangs94 commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
umangs94 commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1233174514

   I understand the reasoning but it would be great if an option could be added to have the old UI back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] umangs94 commented on issue #25992: Add an option to bring back multiline view for values in Airflow UI > Variable List

Posted by GitBox <gi...@apache.org>.
umangs94 commented on issue #25992:
URL: https://github.com/apache/airflow/issues/25992#issuecomment-1233406815

   Unfortunately, a tool tip wouldn't help with being able to find text on the page across all variables. It would be great if we could see the variable value's full text like how @spatocode's screenshot shows it.
   
   If an option for the old UI is not possible, then can you point me in the right direction so that I can modify my local installation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org