Re: svn commit: r8539 - trunk/tools/hook-scripts

["C. Michael Pilato" <cm...@collab.net>]

Branko Čibej <br...@xbc.nu> writes:

> >>Yup, that's the one. Well Mike, do you want to make this a 1.0
> >>candidate? :-)
> >
> >In a modified form, perhaps.  I don't like that propchanges are
> >triggered by '--revprop' which much be the first argument.  I'd rather
> >see a subcommand syntax like our binaries use:
> >
> >  $ commit-mailer.py commit REPOS-DIR REVISION [CONFIGFILE]
> >  $ commit-mailer.py revprop REPOS-DIR REVISION AUTHOR PROPNAME [CONFIGFILE]
> >
> >But other than yet, I love the patch.  Dunno if I wanna hold up a 1.0
> >release for it.  Also, there's a major downside to shipping *only*
> >commit-mailer.py -- the bindings requirement.
> 
> Like this? It's "mailer.py commit" or "mailer.py propchange", the
> subject_prefix parameter becomes commit_subject_prefix, and we grow a
> new parameter propchange_subject_prefix.

Yes yes yes.  This is goodness, syntax and configuration-wise.  I
haven't actually reviewed the code, but as far as the concept (now)
goes, +1.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org